Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2298043003: Convert editing/pasteboard/insert-div-text-into-text.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/insert-div-text-into-text.html to use w3c test harness This patch converts "editing/pasteboard/insert-div-text-into-text.html" to use w3c test harness to simplify test script and moves to "inserting/insert_div_text_into_text.html" since this test checks "insertHTML" command instead of clipboard related command for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/e593fec98c0b285d5aa136a9b2f2610a9f3b9e7e Cr-Commit-Position: refs/heads/master@{#415905}

Patch Set 1 : 2016-08-31T16:28:12 #

Total comments: 2

Patch Set 2 : 2016-09-01T12:27:29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -39 lines) Patch
A + third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html View 1 1 chunk +4 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/insert-div-text-into-text.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/insert-div-text-into-text-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-31 08:37:58 UTC) #5
yoichio
https://codereview.chromium.org/2298043003/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html File third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html (right): https://codereview.chromium.org/2298043003/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html#newcode9 third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html:9: 'There\u{00A0} b|e no line breaks in this sentence.', Is ...
4 years, 3 months ago (2016-09-01 02:12:05 UTC) #8
yosin_UTC9
PTAL Updated. https://codereview.chromium.org/2298043003/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html File third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html (right): https://codereview.chromium.org/2298043003/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html#newcode9 third_party/WebKit/LayoutTests/editing/inserting/insert_div_text_into_text.html:9: 'There\u{00A0} b|e no line breaks in this ...
4 years, 3 months ago (2016-09-01 03:30:55 UTC) #11
yoichio
lgtm
4 years, 3 months ago (2016-09-01 07:41:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298043003/20001
4 years, 3 months ago (2016-09-01 08:03:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 08:07:08 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 08:09:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e593fec98c0b285d5aa136a9b2f2610a9f3b9e7e
Cr-Commit-Position: refs/heads/master@{#415905}

Powered by Google App Engine
This is Rietveld 408576698