Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2297973002: WMPI: Add base::Feature for disabling SurfaceViews. (Closed)

Created:
4 years, 3 months ago by sandersd (OOO until July 31)
Modified:
4 years, 3 months ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WMPI: Add base::Feature for disabling SurfaceViews. BUG=642571 Committed: https://crrev.com/3d927e7a3cf8aec8832391396ae8c99750229345 Cr-Commit-Position: refs/heads/master@{#415815}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adjust member variable name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M media/base/media_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sandersd (OOO until July 31)
4 years, 3 months ago (2016-08-31 00:12:51 UTC) #2
watk
lgtm https://codereview.chromium.org/2297973002/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2297973002/diff/1/media/blink/webmediaplayer_impl.cc#newcode237 media/blink/webmediaplayer_impl.cc:237: disable_video_overlays_ = I think this would be more ...
4 years, 3 months ago (2016-08-31 00:27:45 UTC) #3
sandersd (OOO until July 31)
https://codereview.chromium.org/2297973002/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2297973002/diff/1/media/blink/webmediaplayer_impl.cc#newcode237 media/blink/webmediaplayer_impl.cc:237: disable_video_overlays_ = On 2016/08/31 00:27:45, watk wrote: > I ...
4 years, 3 months ago (2016-08-31 21:43:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297973002/20001
4 years, 3 months ago (2016-08-31 21:49:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 00:15:15 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 00:18:46 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3d927e7a3cf8aec8832391396ae8c99750229345
Cr-Commit-Position: refs/heads/master@{#415815}

Powered by Google App Engine
This is Rietveld 408576698