Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2297973002: WMPI: Add base::Feature for disabling SurfaceViews. (Closed)
Patch Set: Adjust member variable name. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 3389d4a33706376b74273ac2d14951542df66f04..74f894cd343f2db5fed05dfff7a0040aef2ddacc 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -234,6 +234,9 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
force_video_overlays_ = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kForceVideoOverlays);
+ disable_fullscreen_video_overlays_ =
+ !base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo);
+
if (delegate_)
delegate_id_ = delegate_->AddObserver(this);
@@ -331,12 +334,12 @@ void WebMediaPlayerImpl::DisableOverlay() {
}
void WebMediaPlayerImpl::enteredFullscreen() {
- if (!force_video_overlays_)
+ if (!force_video_overlays_ && !disable_fullscreen_video_overlays_)
EnableOverlay();
}
void WebMediaPlayerImpl::exitedFullscreen() {
- if (!force_video_overlays_)
+ if (!force_video_overlays_ && !disable_fullscreen_video_overlays_)
DisableOverlay();
}
« no previous file with comments | « media/blink/webmediaplayer_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698