Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c
Cr-Commit-Position: refs/heads/master@{#416279}

[ymalik, 2016-08-30 23:51:23]

Description was changed from

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=
==========

to

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ymalik, 2016-08-31 13:36:37]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 13:36:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ymalik, 2016-08-31 13:40:11]

Description was changed from

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-31 13:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 13:48:05]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[ymalik, 2016-09-01 03:32:01]

ymalik@chromium.org changed reviewers:
+ vollick@chromium.org

[ymalik, 2016-09-01 03:34:14]

ymalik@chromium.org changed reviewers:
+ tdresser@chromium.org

[ymalik, 2016-09-01 03:34:15]

+tdresser for ui/events

[skobes, 2016-09-01 04:00:17]

skobes@chromium.org changed reviewers:
+ skobes@chromium.org

[skobes, 2016-09-01 04:00:18]

https://codereview.chromium.org/2297943002/diff/40001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2297943002/diff/40001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:26: // the main thread or on the
compositor thread.
This comment is a great explanation for why you are renaming the bit, but reads
pretty confusingly as documentation of "what does this bit actually mean". :)  
I'd suggest adding a little more context while you're in here about how and why
we set this.

[ymalik, 2016-09-01 14:24:29]

https://codereview.chromium.org/2297943002/diff/40001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2297943002/diff/40001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:26: // the main thread or on the
compositor thread.
On 2016/09/01 04:00:18, skobes wrote:
> This comment is a great explanation for why you are renaming the bit, but
reads
> pretty confusingly as documentation of "what does this bit actually mean". :) 

> I'd suggest adding a little more context while you're in here about how and
why
> we set this.

You're absolutely right. Fixed.

[Ian Vollick, 2016-09-01 14:26:24]

Thanks, this would have helped me understand what was happening when I last
looked at the code.

lgtm with nits.

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
File ui/events/blink/input_handler_proxy.cc (right):

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
ui/events/blink/input_handler_proxy.cc:431: // We only want to record "animating
scroll on main thread" reason if
The comment text should be updated, too.

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
File ui/events/blink/input_handler_proxy_unittest.cc (right):

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
ui/events/blink/input_handler_proxy_unittest.cc:2790: // We only want to record
"animating scroll on main thread" reason if it's the
One more spot.

[ymalik, 2016-09-01 14:43:35]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[ymalik, 2016-09-01 14:43:47]

The CQ bit was unchecked by ymalik@chromium.org

[ymalik, 2016-09-01 14:43:58]

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
File ui/events/blink/input_handler_proxy.cc (right):

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
ui/events/blink/input_handler_proxy.cc:431: // We only want to record "animating
scroll on main thread" reason if
On 2016/09/01 14:26:23, Ian Vollick wrote:
> The comment text should be updated, too.

Missed it. Thanks!

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
File ui/events/blink/input_handler_proxy_unittest.cc (right):

https://codereview.chromium.org/2297943002/diff/60001/ui/events/blink/input_h...
ui/events/blink/input_handler_proxy_unittest.cc:2790: // We only want to record
"animating scroll on main thread" reason if it's the
On 2016/09/01 14:26:23, Ian Vollick wrote:
> One more spot.

Done.

[skobes, 2016-09-01 18:11:15]

lgtm

[tdresser, 2016-09-01 18:54:09]

LGTM

[ymalik, 2016-09-02 14:49:04]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2016-09-02 14:49:04]

The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/2297943002/#ps80001
(title: "update more comments")

[commit-bot: I haz the power, 2016-09-02 14:49:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 16:10:32]

Description was changed from

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-02 16:10:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-02 16:12:39]

Description was changed from

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG=642736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c
Cr-Commit-Position: refs/heads/master@{#416279}
==========

[commit-bot: I haz the power, 2016-09-02 16:12:40]

Patchset 5 (id:??) landed as
https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c
Cr-Commit-Position: refs/heads/master@{#416279}