Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ui/events/blink/input_handler_proxy_unittest.cc

Issue 2297943002: Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread (Closed)
Patch Set: update more comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/blink/input_handler_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/blink/input_handler_proxy_unittest.cc
diff --git a/ui/events/blink/input_handler_proxy_unittest.cc b/ui/events/blink/input_handler_proxy_unittest.cc
index e8eb2cb28ccf42abfb5604e8318700c4620517b0..695194b860ef25b4198701e1e5dcb87a05280738 100644
--- a/ui/events/blink/input_handler_proxy_unittest.cc
+++ b/ui/events/blink/input_handler_proxy_unittest.cc
@@ -2780,21 +2780,21 @@ TEST_P(InputHandlerProxyTest, MainThreadScrollingMouseWheelHistograms) {
cc::MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects |
cc::MainThreadScrollingReason::kThreadedScrollingDisabled |
cc::MainThreadScrollingReason::kPageOverlay |
- cc::MainThreadScrollingReason::kAnimatingScrollOnMainThread);
+ cc::MainThreadScrollingReason::kHandlingScrollFromMainThread);
EXPECT_THAT(
histogram_tester().GetAllSamples("Renderer4.MainThreadWheelScrollReason"),
testing::ElementsAre(base::Bucket(1, 1), base::Bucket(3, 1),
base::Bucket(5, 1)));
- // We only want to record "animating scroll on main thread" reason if it's the
- // only reason. If it's not the only reason, the "real" reason for scrolling
- // on main is something else, and we only want to pay attention to that
- // reason. So we should only include this reason in the histogram when its on
- // its own.
+ // We only want to record "Handling scroll from main thread" reason if it's
+ // the only reason. If it's not the only reason, the "real" reason for
+ // scrolling on main is something else, and we only want to pay attention to
+ // that reason. So we should only include this reason in the histogram when
+ // its on its own.
input_handler_->RecordMainThreadScrollingReasonsForTest(
blink::WebGestureDeviceTouchpad,
- cc::MainThreadScrollingReason::kAnimatingScrollOnMainThread);
+ cc::MainThreadScrollingReason::kHandlingScrollFromMainThread);
EXPECT_THAT(
histogram_tester().GetAllSamples("Renderer4.MainThreadWheelScrollReason"),
« no previous file with comments | « ui/events/blink/input_handler_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698