Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2297933003: Disable Download button if current tab is showing offline page already, or an error or interstitial. (Closed)

Created:
4 years, 3 months ago by Dmitry Titov
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Disable Download button if current tab is showing offline page already, or an error or interstitial. BUG=641391, 641393 Review-Url: https://codereview.chromium.org/2296603004 Cr-Commit-Position: refs/heads/master@{#415691} (cherry picked from commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e) Committed: https://chromium.googlesource.com/chromium/src/+/34c37ca4817eb0331a06bf14cd2ffc58af8b2013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Dmitry Titov
4 years, 3 months ago (2016-08-31 20:29:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34c37ca4817eb0331a06bf14cd2ffc58af8b2013.

Powered by Google App Engine
This is Rietveld 408576698