Issue 2297933003: Disable Download button if current tab is showing offline page already, or an error or interstitial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2297933003: Disable Download button if current tab is showing offline page already, or an error or interstitial. (Closed)

Created:
4 years, 3 months ago by Dmitry Titov

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Disable Download button if current tab is showing offline page already, or an error or interstitial. BUG=641391, 641393 Review-Url: https://codereview.chromium.org/2296603004 Cr-Commit-Position: refs/heads/master@{#415691} (cherry picked from commit ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e) Committed: https://chromium.googlesource.com/chromium/src/+/34c37ca4817eb0331a06bf14cd2ffc58af8b2013

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Dmitry Titov

4 years, 3 months ago (2016-08-31 20:29:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
34c37ca4817eb0331a06bf14cd2ffc58af8b2013.