Disable Download button if current tab is showing offline page already, or an error or interstitial.

Disable Download button if current tab is showing offline page already, or an error or interstitial.

BUG=641391, 641393
Committed: https://crrev.com/ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e
Cr-Commit-Position: refs/heads/master@{#415691}

[Dmitry Titov, 2016-08-31 00:59:53]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 01:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-31 01:07:15]

dimich@chromium.org changed reviewers:
+ dfalcantara@chromium.org, twellington@chromium.org

[Dmitry Titov, 2016-08-31 01:07:16]

ptal:
twellington: enable/disable logic for buttons
dfalcantara: OWNERS look

[commit-bot: I haz the power, 2016-08-31 01:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:45:55]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-08-31 16:30:40]

https://codereview.chromium.org/2296603004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
(right):

https://codereview.chromium.org/2296603004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java:577:
return !isChromeScheme && isValidTab;
The logic here and in AppMenuPropertiesDelegate appear to be opposites

[Dmitry Titov, 2016-08-31 17:22:06]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[Dmitry Titov, 2016-08-31 17:22:22]

Fixed, ptal

https://codereview.chromium.org/2296603004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
(right):

https://codereview.chromium.org/2296603004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java:577:
return !isChromeScheme && isValidTab;
On 2016/08/31 16:30:40, Theresa Wellington wrote:
> The logic here and in AppMenuPropertiesDelegate appear to be opposites

Funny that's what renaming of a variable after building/testing does. Thanks! :)

[commit-bot: I haz the power, 2016-08-31 17:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-08-31 17:29:54]

lgtm

[gone, 2016-08-31 17:33:16]

lgtm

[commit-bot: I haz the power, 2016-08-31 18:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 18:14:00]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2016-08-31 18:27:13]

The CQ bit was checked by dimich@chromium.org

[commit-bot: I haz the power, 2016-08-31 18:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 18:35:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 18:37:30]

Description was changed from

==========
Disable Download button if current tab is showing offline page already, or an
error or interstitial.

BUG=641391,641393
==========

to

==========
Disable Download button if current tab is showing offline page already, or an
error or interstitial.

BUG=641391,641393

Committed: https://crrev.com/ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e
Cr-Commit-Position: refs/heads/master@{#415691}
==========

[commit-bot: I haz the power, 2016-08-31 18:37:31]

Patchset 3 (id:??) landed as
https://crrev.com/ef9788fc36a0a6dbc16c20b9c1c63529c9bb027e
Cr-Commit-Position: refs/heads/master@{#415691}