Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2297743003: ozone/platform/wayland: Add missing header base/bind.h (Closed)

Created:
4 years, 3 months ago by fwang
Modified:
4 years, 3 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone/platform/wayland: Add missing header base/bind.h CL includes the header defining base::Bind in order to fix the following build error for Ozone/Wayland: ui/ozone/platform/wayland/wayland_window.cc:156:27: error: no member named 'Bind' in namespace 'base' native_event, base::Bind(&PlatformWindowDelegate::DispatchEvent, ~~~~~~^ ui/ozone/platform/wayland/wayland_window.cc:157:38: error: no member named 'Unretained' in namespace 'base' base::Unretained(delegate_))); BUG=578890 R=spang@chromium.org Committed: https://crrev.com/54041d62f2ece007b0e289fa66ad89ecc3c39135 Cr-Commit-Position: refs/heads/master@{#416247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/ozone/platform/wayland/wayland_window.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
not to use - tonikitoo
informal l-g-t-m.
4 years, 3 months ago (2016-09-01 16:02:25 UTC) #4
rjkroege
lgtm
4 years, 3 months ago (2016-09-01 20:13:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297743003/1
4 years, 3 months ago (2016-09-02 12:04:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 12:44:03 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 12:46:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54041d62f2ece007b0e289fa66ad89ecc3c39135
Cr-Commit-Position: refs/heads/master@{#416247}

Powered by Google App Engine
This is Rietveld 408576698