Store default search provider data in dictionary pref.

chrome/browser/search_engines/template_url_keys.h

Index: chrome/browser/search_engines/template_url_keys.h
diff --git a/chrome/browser/search_engines/template_url_keys.h b/chrome/browser/search_engines/template_url_keys.h
new file mode 100644
index 0000000000000000000000000000000000000000..198e5224bc97137c9c8faccd0e386b304a4fe2e9
--- /dev/null
+++ b/chrome/browser/search_engines/template_url_keys.h
@@ -0,0 +1,44 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Constants for the keys of the kDefaultSearchProviderData pref.
+
+#ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_KEYS_H_
+#define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_KEYS_H_
+
+namespace default_search {

[Peter Kasting, 2014/04/23 20:41:06]

Using a namespace for this, especially one that doesn't match anything in the
file/path name of the containing file, is unusual.  I'd prefer to do something
more in keeping with typical Chrome practice.

What this would be depends on where you intend to use these.  Right now, they're
only used in default_search_manager.cc, and could thus be in an anonymous
namespace atop that file.  Going forward, if you intend to use them elsewhere,
they could perhaps be public members of DefaultSearchManager.

[Cait (Slow), 2014/04/23 23:26:55]

They will be needed to populate the dictionary from policy values as well, so I
think public members of DefaultSearchManager is the best option.

+
+extern const char kID[];
+extern const char kShortName[];
+extern const char kKeyword[];
+extern const char kPrepopulateID[];
+extern const char kSyncGUID[];
+
+extern const char kURL[];
+extern const char kSuggestionsURL[];
+extern const char kInstantURL[];
+extern const char kImageURL[];
+extern const char kNewTabURL[];
+extern const char kFaviconURL[];
+extern const char kOriginatingURL[];
+
+extern const char kSearchURLPostParams[];
+extern const char kSuggestionsURLPostParams[];
+extern const char kInstantURLPostParams[];
+extern const char kImageURLPostParams[];
+
+extern const char kSafeForAutoReplace[];
+extern const char kInputEncodings[];
+
+extern const char kDateCreated[];
+extern const char kLastModified[];
+
+extern const char kUsageCount[];
+extern const char kAlternateURLs[];
+extern const char kSearchTermsReplacementKey[];
+extern const char kCreatedByPolicy[];
+
+}  // namespace default_search
+
+#endif  // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_KEYS_H_