chrome/browser/search_engines/template_url_keys.h - Issue 229763005: Store default search provider data in dictionary pref.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/search_engines/template_url_keys.h

Issue 229763005: Store default search provider data in dictionary pref. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Eriks comments and clean up Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/search_engines/default_search_manager_unittest.cc ('K') | « chrome/browser/search_engines/default_search_manager_unittest.cc ('k') | chrome/browser/search_engines/template_url_keys.cc » ('j') | chrome/browser/search_engines/template_url_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Constants for the keys of the kDefaultSearchProviderData pref.

	6

	7 #ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_KEYS_H_

	8 #define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_KEYS_H_

	9

	10 namespace default_search {
	Peter Kasting 2014/04/23 20:41:06 Using a namespace for this, especially one that do Using a namespace for this, especially one that doesn't match anything in the file/path name of the containing file, is unusual. I'd prefer to do something more in keeping with typical Chrome practice. What this would be depends on where you intend to use these. Right now, they're only used in default_search_manager.cc, and could thus be in an anonymous namespace atop that file. Going forward, if you intend to use them elsewhere, they could perhaps be public members of DefaultSearchManager. Cait (Slow) 2014/04/23 23:26:55 They will be needed to populate the dictionary fro Show quoted text On 2014/04/23 20:41:06, Peter Kasting wrote: > Using a namespace for this, especially one that doesn't match anything in the > file/path name of the containing file, is unusual. I'd prefer to do something > more in keeping with typical Chrome practice. > > What this would be depends on where you intend to use these. Right now, they're > only used in default_search_manager.cc, and could thus be in an anonymous > namespace atop that file. Going forward, if you intend to use them elsewhere, > they could perhaps be public members of DefaultSearchManager. They will be needed to populate the dictionary from policy values as well, so I think public members of DefaultSearchManager is the best option.
	11

	12 extern const char kID[];

	13 extern const char kShortName[];

	14 extern const char kKeyword[];

	15 extern const char kPrepopulateID[];

	16 extern const char kSyncGUID[];

	17

	18 extern const char kURL[];

	19 extern const char kSuggestionsURL[];

	20 extern const char kInstantURL[];

	21 extern const char kImageURL[];

	22 extern const char kNewTabURL[];

	23 extern const char kFaviconURL[];

	24 extern const char kOriginatingURL[];

	25

	26 extern const char kSearchURLPostParams[];

	27 extern const char kSuggestionsURLPostParams[];

	28 extern const char kInstantURLPostParams[];

	29 extern const char kImageURLPostParams[];

	30

	31 extern const char kSafeForAutoReplace[];

	32 extern const char kInputEncodings[];

	33

	34 extern const char kDateCreated[];

	35 extern const char kLastModified[];

	36

	37 extern const char kUsageCount[];

	38 extern const char kAlternateURLs[];

	39 extern const char kSearchTermsReplacementKey[];

	40 extern const char kCreatedByPolicy[];

	41

	42 } // namespace default_search

	43

	44 #endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_KEYS_H_

OLD	NEW