third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2297503002: Fix usage of DocumentLifecycle::DisallowTransitionScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2297503002: Fix usage of DocumentLifecycle::DisallowTransitionScope (Closed)

Patch Set: Add missing layout update Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 259c12ece4c8f34f3965885f40c6ba3bef2798de..e23523445ac0b163f50b90aa006eacb939dc761a 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1073,7 +1073,7 @@ void WebLocalFrameImpl::requestTextChecking(const WebElement& webElement)

// see http://crbug.com/590369 for more details.

frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();

- DocumentLifecycle::DisallowTransitionScope(frame()->document()->lifecycle());

+ DocumentLifecycle::DisallowTransitionScope disallowTransition(frame()->document()->lifecycle());

frame()->spellChecker().requestTextChecking(*webElement.constUnwrap<Element>());

}

@@ -1157,7 +1157,7 @@ void WebLocalFrameImpl::selectRange(const WebRange& webRange)

// see http://crbug.com/590369 for more details.

frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();

- DocumentLifecycle::DisallowTransitionScope(frame()->document()->lifecycle());

+ DocumentLifecycle::DisallowTransitionScope disallowTransition(frame()->document()->lifecycle());

frame()->selection().setSelectedRange(webRange.createEphemeralRange(frame()), VP_DEFAULT_AFFINITY, SelectionDirectionalMode::NonDirectional, NotUserTriggered);

}

@@ -1168,7 +1168,7 @@ WebString WebLocalFrameImpl::rangeAsText(const WebRange& webRange)

// see http://crbug.com/590369 for more details.

frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();

- DocumentLifecycle::DisallowTransitionScope(frame()->document()->lifecycle());

+ DocumentLifecycle::DisallowTransitionScope disallowTransition(frame()->document()->lifecycle());

return plainText(webRange.createEphemeralRange(frame()), TextIteratorEmitsObjectReplacementCharacter);

}