Save password functionality added to the save password bubble

chrome/browser/password_manager/password_form_manager.h

Index: chrome/browser/password_manager/password_form_manager.h
diff --git a/chrome/browser/password_manager/password_form_manager.h b/chrome/browser/password_manager/password_form_manager.h
index 877729908a3cae9cd0c2c6adcad5cd15fed6e344..c2e8401072c4660067eaa327daae4bd3c32a10fd 100644
--- a/chrome/browser/password_manager/password_form_manager.h
+++ b/chrome/browser/password_manager/password_form_manager.h
@@ -71,6 +71,18 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // the same thread!
   bool HasCompletedMatching();
 
+  // Sets |should_save_password_| to true which means the password will be
+  // saved upon the next navigation.

[Garrett Casto, 2013/09/03 23:46:43]

I try to write comments in the header as a consumer of the function would read
them. So something more like "Sets current password to be saved when
ApplyEdits() is called. Will override a previous call to BlacklistPassword()".

[npentrel, 2013/09/04 08:32:23]

Done.

+  void SavePassword();
+
+  // Sets |should_blacklist_password_| to true which means the password will be
+  // blacklisted upon the next navigation.

[Garrett Casto, 2013/09/03 23:46:43]

Similar to above.

[npentrel, 2013/09/04 08:32:23]

Done.

+  void BlacklistPassword();
+
+  // Applies the change, i.e. saves or blacklists password according to
+  // |should_blacklist_password_| and |should_save_password_|.

[Garrett Casto, 2013/09/03 23:46:43]

Something like "Persist changes from the latest call to either SavePassword() or
BlacklistPassword()."

[npentrel, 2013/09/04 08:32:23]

Done.

+  void ApplyChange();
+
   // Determines if the user opted to 'never remember' passwords for this form.
   bool IsBlacklisted();
 
@@ -291,6 +303,8 @@ class PasswordFormManager : public PasswordStoreConsumer {
   ManagerAction manager_action_;
   UserAction user_action_;
   SubmitResult submit_result_;
+  bool should_save_password_;
+  bool should_blacklist_password_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };