Save password functionality added to the save password bubble

chrome/browser/password_manager/password_form_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 53 matching lines @@
   // conceivable that a user (or ui test) could attempt to submit a login
   // prompt before the callback has occured, which would InvokeLater a call to
   // PasswordManager::ProvisionallySave, which would interact with this object
   // before the db has had time to answer with matching password entries.
   // This is intended to be a one-time check; if the return value is false the
   // expectation is caller will give up. This clearly won't work if you put it
   // in a loop and wait for matching to complete; you're (supposed to be) on
   // the same thread!
   bool HasCompletedMatching();
 
+  // Sets |should_save_password_| to true which means the password will be
+  // saved upon the next navigation.

[Garrett Casto, 2013/09/03 23:46:43]

I try to write comments in the header as a consumer of the function would read
them. So something more like "Sets current password to be saved when
ApplyEdits() is called. Will override a previous call to BlacklistPassword()".

[npentrel, 2013/09/04 08:32:23]

Done.

+  void SavePassword();
+
+  // Sets |should_blacklist_password_| to true which means the password will be
+  // blacklisted upon the next navigation.

[Garrett Casto, 2013/09/03 23:46:43]

Similar to above.

[npentrel, 2013/09/04 08:32:23]

Done.

+  void BlacklistPassword();
+
+  // Applies the change, i.e. saves or blacklists password according to
+  // |should_blacklist_password_| and |should_save_password_|.

[Garrett Casto, 2013/09/03 23:46:43]

Something like "Persist changes from the latest call to either SavePassword() or
BlacklistPassword()."

[npentrel, 2013/09/04 08:32:23]

Done.

+  void ApplyChange();
+
   // Determines if the user opted to 'never remember' passwords for this form.
   bool IsBlacklisted();
 
   // Used by PasswordManager to determine whether or not to display
   // a SavePasswordBar when given the green light to save the PasswordForm
   // managed by this.
   bool IsNewLogin();
 
   // Returns true if the current pending credentials were found using
   // origin matching of the public suffix, instead of the signon realm of the
@@ skipping 13 matching lines @@
   void OnRequestDone(const std::vector<content::PasswordForm*>& result);
 
   // PasswordStoreConsumer implementation.
   virtual void OnPasswordStoreRequestDone(
       CancelableRequestProvider::Handle handle,
       const std::vector<content::PasswordForm*>& result) OVERRIDE;
   virtual void OnGetPasswordStoreResults(
       const std::vector<content::PasswordForm*>& results) OVERRIDE;
 
   // A user opted to 'never remember' passwords for this form.
   // Blacklist it so that from now on when it is seen we ignore it.

[Garrett Casto, 2013/09/03 23:46:43]

Add a TODO here to make this private once we switch to the new UI.

[npentrel, 2013/09/04 08:32:23]

Done.

   void PermanentlyBlacklist();
 
   // If the user has submitted observed_form_, provisionally hold on to
   // the submitted credentials until we are told by PasswordManager whether
   // or not the login was successful. |action| describes how we deal with
   // possible usernames. If |action| is ALLOW_OTHER_POSSIBLE_USERNAMES we will
   // treat a possible usernames match as a sign that our original heuristics
   // were wrong and that the user selected the correct username from the
   // Autofill UI.
   void ProvisionallySave(const content::PasswordForm& credentials,
                          OtherPossibleUsernamesAction action);
 
   // Handles save-as-new or update of the form managed by this manager.
   // Note the basic data of updated_credentials must match that of
   // observed_form_ (e.g DoesManage(pending_credentials_) == true).

[Garrett Casto, 2013/09/03 23:46:43]

Same here.

[npentrel, 2013/09/04 08:32:23]

Done.

   void Save();
 
   // Call these if/when we know the form submission worked or failed.
   // These routines are used to update internal statistics ("ActionsTaken").
   void SubmitPassed();
   void SubmitFailed();
 
   // Return the username associated with the credentials.
   const string16& associated_username() const {
     return pending_credentials_.username_value;
@@ skipping 151 matching lines @@
   // Web contents from which we get the RenderViewHost for sending messages to
   // the corresponding renderer.
   content::WebContents* web_contents_;
 
   // These three fields record the "ActionsTaken" by the browser and
   // the user with this form, and the result. They are combined and
   // recorded in UMA when the manager is destroyed.
   ManagerAction manager_action_;
   UserAction user_action_;
   SubmitResult submit_result_;
+  bool should_save_password_;
+  bool should_blacklist_password_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_