Make XMLHttpRequest.open() throw for invalid URLs

Make XMLHttpRequest.open() throw for invalid URLs

Also adds tests for invalid/forbidden methods.

R=yhirano@chromium.org
BUG=642239
Committed: https://crrev.com/a0bab936d014e4c74e7d8bfcdb7be5a74b69c6a4
Cr-Commit-Position: refs/heads/master@{#415932}

[tyoshino (SeeGerritForStatus), 2016-08-30 05:02:47]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 05:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 06:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 06:49:26]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-08-30 07:51:01]

Description was changed from

==========
Make XMLHttpRequest.open() throw for invalid URLs

BUG=642239
==========

to

==========
Make XMLHttpRequest.open() throw for invalid URLs

BUG=642239
==========

[tyoshino (SeeGerritForStatus), 2016-08-30 07:51:01]

tyoshino@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2016-08-31 01:53:41]

According to the spec the method should be checked before the URL.

[tyoshino (SeeGerritForStatus), 2016-09-01 05:57:52]

On 2016/08/31 01:53:41, yhirano wrote:
> According to the spec the method should be checked before the URL.

Fixed. PTAL

[tyoshino (SeeGerritForStatus), 2016-09-01 05:58:01]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 05:58:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-01 07:02:42]

lgtm

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html
(right):

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html:45:
}, 'open() should throw for a SyntaxError for an invalid method');
wrong description

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html:48:
}, 'open() with a forbidden method is no-op');
wrong name

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp:584:
DCHECK(url.isValid());
[optional] DCHECK(validateOpenArguments(...))?

[commit-bot: I haz the power, 2016-09-01 07:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 07:19:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tyoshino (SeeGerritForStatus), 2016-09-01 10:15:57]

Description was changed from

==========
Make XMLHttpRequest.open() throw for invalid URLs

BUG=642239
==========

to

==========
Make XMLHttpRequest.open() throw for invalid URLs

Also adds tests for invalid/forbidden methods.

R=yhirano@chromium.org
BUG=642239
==========

[tyoshino (SeeGerritForStatus), 2016-09-01 10:19:41]

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html
(right):

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html:45:
}, 'open() should throw for a SyntaxError for an invalid method');
On 2016/09/01 07:02:42, yhirano wrote:
> wrong description

Good catches. Fixed

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html:48:
}, 'open() with a forbidden method is no-op');
On 2016/09/01 07:02:42, yhirano wrote:
> wrong name

Done.

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/2297483002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp:584:
DCHECK(url.isValid());
On 2016/09/01 07:02:42, yhirano wrote:
> [optional] DCHECK(validateOpenArguments(...))?

Done.

[tyoshino (SeeGerritForStatus), 2016-09-01 10:19:47]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-01 10:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2297483002/#ps80001
(title: "Addressed #12")

[commit-bot: I haz the power, 2016-09-01 10:20:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 11:37:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-01 11:39:50]

Description was changed from

==========
Make XMLHttpRequest.open() throw for invalid URLs

Also adds tests for invalid/forbidden methods.

R=yhirano@chromium.org
BUG=642239
==========

to

==========
Make XMLHttpRequest.open() throw for invalid URLs

Also adds tests for invalid/forbidden methods.

R=yhirano@chromium.org
BUG=642239

Committed: https://crrev.com/a0bab936d014e4c74e7d8bfcdb7be5a74b69c6a4
Cr-Commit-Position: refs/heads/master@{#415932}
==========

[commit-bot: I haz the power, 2016-09-01 11:39:51]

Patchset 5 (id:??) landed as
https://crrev.com/a0bab936d014e4c74e7d8bfcdb7be5a74b69c6a4
Cr-Commit-Position: refs/heads/master@{#415932}