third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html - Issue 2297483002: Make XMLHttpRequest.open() throw for invalid URLs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-with-invalid-argument-is-noop.html

Issue 2297483002: Make XMLHttpRequest.open() throw for invalid URLs (Closed)

Patch Set: Test that invalid open() is no-op Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-unsupported-url.js » ('j') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 async_test(t => {

	6 const xhr = new XMLHttpRequest();

	7 xhr.open('GET', 'resources/get.txt');

	8 xhr.onload = t.step_func(() => {

	9 assert_equals(xhr.responseText, 'PASS');

	10 t.done();

	11 });

	12

	13 assert_throws('SyntaxError', () => {

	14 xhr.open('FOO BAR', 'nonexistent');

	15 }, 'open() should throw for a SyntaxError for an invalid method');

	16

	17 xhr.send();

	18 }, 'open() with an invalid method is no-op');

	19

	20 async_test(t => {

	21 const xhr = new XMLHttpRequest();

	22 xhr.open('GET', 'resources/get.txt');

	23 xhr.onload = t.step_func(() => {

	24 assert_equals(xhr.responseText, 'PASS');

	25 t.done();

	26 });

	27

	28 assert_throws('SecurityError', () => {

	29 xhr.open('CONNECT', 'nonexistent');

	30 }, 'open() should throw for a SecurityError for a forbidden method');

	31

	32 xhr.send();

	33 }, 'open() with a forbidden method is no-op');

	34

	35 async_test(t => {

	36 const xhr = new XMLHttpRequest();

	37 xhr.open('GET', 'resources/get.txt');

	38 xhr.onload = t.step_func(() => {

	39 assert_equals(xhr.responseText, 'PASS');

	40 t.done();

	41 });

	42

	43 assert_throws('SyntaxError', () => {

	44 xhr.open('GET', 'http://localhost:foobar/');

	45 }, 'open() should throw for a SyntaxError for an invalid method');
	yhirano 2016/09/01 07:02:42 wrong description wrong description tyoshino (SeeGerritForStatus) 2016/09/01 10:19:41 Good catches. Fixed Show quoted text On 2016/09/01 07:02:42, yhirano wrote: > wrong description Good catches. Fixed
	46

	47 xhr.send();

	48 }, 'open() with a forbidden method is no-op');
	yhirano 2016/09/01 07:02:42 wrong name wrong name tyoshino (SeeGerritForStatus) 2016/09/01 10:19:41 Done. Show quoted text On 2016/09/01 07:02:42, yhirano wrote: > wrong name Done.
	49 </script>

OLD	NEW