On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

In Apple's WebKit, AXLayoutComplete, and not AXLoadComplete, fires when an iframe loads. I am not sure if it also fires when an iframe finishes layout, so we should leave the |ui::AX_EVENT_LAYOUT_COMPLETE| case in for now.
BUG=637895
TESTED=Voiceover
R=dmazzoni@chromium.org

Committed: https://crrev.com/a95b71765f7160f1e5d7b09ede730d223492a595
Cr-Commit-Position: refs/heads/master@{#415413}

[dmazzoni, 2016-08-29 21:32:33]

lgtm

Thanks. What's the user-visible bug you observe with this?

[dmazzoni, 2016-08-29 21:33:08]

On 2016/08/29 at 21:32:33, dmazzoni wrote:
> lgtm
> 
> Thanks. What's the user-visible bug you observe with this?

Oh, just saw the linked bug - that's great if this fixes the issues with
some pages reloading!

[chromium-reviews, 2016-08-30 00:21:31]

Okay, works properly now.
Could you have another look?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-08-30 14:04:16]

still lgtm

Let's land this because it fixes a solid user-facing bug and we
may want to merge this small patch, but
I'd like to refactor things more to make it clear. Please file a
bug and assign to me to make BrowserAccessibilityDelegate::IsTreeRoot
a proper API rather than something that falls out of whether or not
there's an accelerated widget - and also to write some tests for it.

It's not at all obvious that it works correctly for out of process
iframes and browser plugins, but it does because RFHI will own a
RenderWidgetHostViewChildFrame instead of a platform-specific subclass,
and RWHVCF doesn't implement ...AcceleratedWidget. So yeah, it seems
to do the right thing but it's not at all obvious why and needs to
be cleaned up.

You'll need another owner - perhaps asvitkine@chromium.org who owns
content/browser/renderer_host/*mac, otherwise nasko@ or creis@
have reviewed some accessibility APIs.

[nektarios, 2016-08-30 16:43:36]

Description was changed from

==========
On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

In Apple's WebKit, AXLayoutComplete fires when an iframe loads. I am not sure if
it also fires when an iframe finishes layout.
BUG=637895
TESTED=Voiceover
R=dmazzoni@chromium.org
==========

to

==========
On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

In Apple's WebKit, AXLayoutComplete, and not AXLoadComplete, fires when an
iframe loads. I am not sure if it also fires when an iframe finishes layout, so
we should leave the |ui::AX_EVENT_LAYOUT_COMPLETE| case in for now.
BUG=637895
TESTED=Voiceover
R=dmazzoni@chromium.org
==========

[nektarios, 2016-08-30 16:43:36]

nektar@chromium.org changed reviewers:
+ asvitkine@chromium.org

[nektarios, 2016-08-30 16:45:05]

@asvitkine
Please review changes to content/browser/renderer_host/.
+ellyjones for visibility.

[nektarios, 2016-08-30 16:45:05]

@asvitkine
Please review changes to content/browser/renderer_host/.
+ellyjones for visibility.

[nektarios, 2016-08-30 16:54:16]

On 2016/08/30 at 16:45:05, nektarios wrote:
> @asvitkine
> Please review changes to content/browser/renderer_host/.
> +ellyjones for visibility.

@dmazzoni
Issue http://crbug.com/642393 created and assigned to you.

[Alexei Svitkine (slow), 2016-08-30 18:03:27]

lgtm

[nektarios, 2016-08-30 18:32:59]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-08-30 18:32:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2297433002/#ps100001
(title: "Compiler fix.")

[commit-bot: I haz the power, 2016-08-30 18:33:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:39:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2016-08-30 19:40:14]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:37:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-30 20:40:18]

Description was changed from

==========
On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

In Apple's WebKit, AXLayoutComplete, and not AXLoadComplete, fires when an
iframe loads. I am not sure if it also fires when an iframe finishes layout, so
we should leave the |ui::AX_EVENT_LAYOUT_COMPLETE| case in for now.
BUG=637895
TESTED=Voiceover
R=dmazzoni@chromium.org
==========

to

==========
On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

In Apple's WebKit, AXLayoutComplete, and not AXLoadComplete, fires when an
iframe loads. I am not sure if it also fires when an iframe finishes layout, so
we should leave the |ui::AX_EVENT_LAYOUT_COMPLETE| case in for now.
BUG=637895
TESTED=Voiceover
R=dmazzoni@chromium.org

Committed: https://crrev.com/a95b71765f7160f1e5d7b09ede730d223492a595
Cr-Commit-Position: refs/heads/master@{#415413}
==========

[commit-bot: I haz the power, 2016-08-30 20:40:20]

Patchset 6 (id:??) landed as
https://crrev.com/a95b71765f7160f1e5d7b09ede730d223492a595
Cr-Commit-Position: refs/heads/master@{#415413}