content/browser/accessibility/browser_accessibility_manager_mac.mm - Issue 2297433002: On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 2297433002: On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compiler fix. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_mac.mm

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm

index b2dff5cf91602e237a02682f2ad1f5baf62a74f6..77ce72f4df5882ac45c0533656d8cbfffcdd961b 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm

@@ -191,7 +191,14 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(

mac_notification = NSAccessibilityLayoutCompleteNotification;

break;

case ui::AX_EVENT_LOAD_COMPLETE:

- mac_notification = NSAccessibilityLoadCompleteNotification;

+ // This notification should only be fired on the top document.

+ // Iframes should use |AX_EVENT_LAYOUT_COMPLETE| to signify that they have

+ // finished loading.

+ if (IsRootTree()) {

+ mac_notification = NSAccessibilityLoadCompleteNotification;

+ } else {

+ mac_notification = NSAccessibilityLayoutCompleteNotification;

+ }

break;

case ui::AX_EVENT_INVALID_STATUS_CHANGED:

mac_notification = NSAccessibilityInvalidStatusChangedNotification;