Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 2297263002: Revert "Only allow HTTP/0.9 support on default ports." (Closed)

Created:
2 years, 5 months ago by mmenke
Modified:
2 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tnagel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Only allow HTTP/0.9 support on default ports." The CL broke some websocket layout tests, will reland once that's worked out. This reverts commit 398c105ea8391473126021104554d70fda08324b. Also add a group policy to allow HTTP/0.9 support on other ports, which I plan to remove in a couple revisions. BUG=624462, 637017 Committed: https://crrev.com/398c105ea8391473126021104554d70fda08324b Cr-Commit-Position: refs/heads/master@{#415643} TBR=eroman@chromium.org NOTRY=true Committed: https://crrev.com/400eb587ad05c2aef8740e2bff550083ac90ea2d Cr-Commit-Position: refs/heads/master@{#415668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -335 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/io_thread.cc View 5 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 3 chunks +0 lines, -45 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +0 lines, -3 lines 0 comments Download
M components/policy/resources/policy_templates.json View 2 chunks +1 line, -22 lines 0 comments Download
M net/http/http_basic_state.h View 3 chunks +1 line, -8 lines 0 comments Download
M net/http/http_basic_state.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M net/http/http_basic_state_unittest.cc View 5 chunks +8 lines, -15 lines 0 comments Download
M net/http/http_basic_stream.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_basic_stream.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +1 line, -53 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_stream_parser.h View 2 chunks +0 lines, -11 lines 0 comments Download
M net/http/http_stream_parser.cc View 3 chunks +1 line, -16 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 4 chunks +15 lines, -95 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/test/embedded_test_server/default_handlers.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
mmenke
TBRing this, also going to TBR the reland (Perhaps other than the websocket test changes).
2 years, 5 months ago (2016-08-31 17:15:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297263002/1
2 years, 5 months ago (2016-08-31 17:16:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 5 months ago (2016-08-31 17:21:27 UTC) #8
commit-bot: I haz the power
2 years, 5 months ago (2016-08-31 17:23:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400eb587ad05c2aef8740e2bff550083ac90ea2d
Cr-Commit-Position: refs/heads/master@{#415668}

Powered by Google App Engine
This is Rietveld 408576698