Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/browser/net/errorpage_browsertest.cc

Issue 2297263002: Revert "Only allow HTTP/0.9 support on default ports." (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread_unittest.cc ('k') | chrome/test/data/policy/policy_test_cases.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/errorpage_browsertest.cc
diff --git a/chrome/browser/net/errorpage_browsertest.cc b/chrome/browser/net/errorpage_browsertest.cc
index b9be20fdf6ba65ba0c8b7a48ce5e68190bf57229..e489c932a9c0f7e7ebca8e6f71b2133395414cbd 100644
--- a/chrome/browser/net/errorpage_browsertest.cc
+++ b/chrome/browser/net/errorpage_browsertest.cc
@@ -17,7 +17,6 @@
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/lock.h"
-#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/browsing_data_remover.h"
@@ -36,9 +35,6 @@
#include "chrome/test/base/ui_test_utils.h"
#include "components/error_page/common/error_page_switches.h"
#include "components/google/core/browser/google_util.h"
-#include "components/policy/core/browser/browser_policy_connector.h"
-#include "components/policy/core/common/mock_configuration_policy_provider.h"
-#include "components/policy/core/common/policy_map.h"
#include "components/policy/policy_constants.h"
#include "components/prefs/pref_service.h"
#include "components/strings/grit/components_strings.h"
@@ -1498,45 +1494,4 @@ IN_PROC_BROWSER_TEST_F(ErrorPageForIDNTest, IDN) {
EXPECT_TRUE(IsDisplayingText(browser(), kHostnameJSUnicode));
}
-// Make sure HTTP/0.9 is disabled on non-default ports by default.
-IN_PROC_BROWSER_TEST_F(ErrorPageTest, Http09WeirdPort) {
- ASSERT_TRUE(embedded_test_server()->Start());
- ui_test_utils::NavigateToURL(
- browser(), embedded_test_server()->GetURL("/echo-raw?spam"));
- ExpectDisplayingLocalErrorPage(browser(), net::ERR_INVALID_HTTP_RESPONSE);
-}
-
-class ErrorPageWithHttp09OnNonDefaultPortsTest : public InProcessBrowserTest {
- public:
- // InProcessBrowserTest:
- void SetUp() override {
- EXPECT_CALL(policy_provider_, IsInitializationComplete(testing::_))
- .WillRepeatedly(testing::Return(true));
- policy::PolicyMap values;
- values.Set(policy::key::kHttp09OnNonDefaultPortsEnabled,
- policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_MACHINE,
- policy::POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::FundamentalValue(true)), nullptr);
- policy_provider_.UpdateChromePolicy(values);
- policy::BrowserPolicyConnector::SetPolicyProviderForTesting(
- &policy_provider_);
-
- InProcessBrowserTest::SetUp();
- }
-
- private:
- policy::MockConfigurationPolicyProvider policy_provider_;
-};
-
-// Make sure HTTP/0.9 works on non-default ports when enabled by policy.
-IN_PROC_BROWSER_TEST_F(ErrorPageWithHttp09OnNonDefaultPortsTest,
- Http09WeirdPortEnabled) {
- const char kHttp09Response[] = "JumboShrimp";
- ASSERT_TRUE(embedded_test_server()->Start());
- ui_test_utils::NavigateToURL(
- browser(), embedded_test_server()->GetURL(std::string("/echo-raw?") +
- kHttp09Response));
- EXPECT_TRUE(IsDisplayingText(browser(), kHttp09Response));
-}
-
} // namespace
« no previous file with comments | « chrome/browser/io_thread_unittest.cc ('k') | chrome/test/data/policy/policy_test_cases.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698