Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2297043002: Web expose FileSystemFileEntry, FileSystemDirectoryEntry and friends (Closed)

Created:
4 years, 3 months ago by jsbell
Modified:
3 years, 7 months ago
Reviewers:
foolip
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-api_chromium.org, tzik, nhiroki, pfeldman+blink_chromium.org, haraken, dglazkov+blink, blink-reviews-bindings_chromium.org, lushnikov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kinuko+watch, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web expose FileSystemFileEntry, FileSystemDirectoryEntry and friends Drop [NoInterfaceObject] and rename these types: * DOMFileSystem -> FileSystem * Entry -> FileSystemEntry * FileEntry -> FileSystemFileEntry * DirectoryEntry -> FileSystemDirectoryEntry * DirectoryReader -> FileSystemDirectoryReader The C++ types are also renamed, as are the *Sync variations and some related classes, although they remain non-exposed. Spec: https://wicg.github.io/entries-api/ Spec PR: https://github.com/WICG/entries-api/pull/8 Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xTfeHGlcIQg/X0Q4iDJHAgAJ ChromeStatus: https://www.chromestatus.com/feature/6698113687355392 R=foolip@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Alphabetize forward declarations #

Patch Set 4 : Remove redundant ImplementedAs #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1918 lines, -5089 lines) Patch
M chrome/browser/chromeos/file_manager/fileapi_util.h View 1 2 3 4 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 1 2 3 4 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/api/file_system.idl View 1 2 3 4 7 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/extensions/api/image_writer_private.idl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/log_private.idl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/media_galleries.idl View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/sync_file_system.idl View 1 2 3 4 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/app_file_handler_multi/test.js View 1 2 3 4 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/drive_search_test/test.js View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/file_browser_handler/background.js View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/file_watcher_test/test.js View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/handler_test_runner/test.js View 1 2 3 4 6 chunks +11 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/multi_profile_copy/test.js View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/test_util/test_util.js View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.js View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/delete_access/test.js View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/sync_file_system/on_file_status_changed/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/sync_file_system/on_file_status_changed_deleted/test.js View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/sync_file_system/request_file_system/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/get_display_path/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/resource_converter.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/app_runtime.idl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/runtime.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_post_message.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M storage/common/fileapi/file_system_info.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializationTag.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp View 1 2 3 4 7 chunks +18 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueDeserializerForModules.cpp View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModules.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp View 1 2 3 4 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/BUILD.gn View 1 2 3 4 2 chunks +29 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFilePath.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h View 1 2 3 4 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 1 2 3 4 1 chunk +0 lines, -201 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystem.idl View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.h View 1 2 3 4 1 chunk +0 lines, -186 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp View 1 2 3 4 1 chunk +0 lines, -464 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystemBaseTest.cpp View 1 2 3 4 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.h View 1 2 3 4 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp View 1 2 3 4 1 chunk +0 lines, -220 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.cpp View 1 2 3 4 4 chunks +12 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp View 1 2 3 4 3 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DedicatedWorkerGlobalScopeFileSystem.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.h View 1 2 3 4 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.cpp View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryEntry.h View 1 2 3 4 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryEntry.cpp View 1 2 3 4 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryEntry.idl View 1 2 3 4 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.h View 1 2 3 4 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.cpp View 1 2 3 4 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.idl View 1 2 3 4 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReader.h View 1 2 3 4 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp View 1 2 3 4 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReader.idl View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReaderBase.h View 1 2 3 4 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.h View 1 2 3 4 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp View 1 2 3 4 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.idl View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntriesCallback.h View 1 2 3 4 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntriesCallback.idl View 1 2 3 4 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/Entry.h View 1 2 3 4 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/Entry.cpp View 1 2 3 4 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/Entry.idl View 1 2 3 4 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntryBase.h View 1 2 3 4 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntryBase.cpp View 1 2 3 4 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntryCallback.h View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntryCallback.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntrySync.h View 1 2 3 4 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntrySync.cpp View 1 2 3 4 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/EntrySync.idl View 1 2 3 4 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/ErrorCallback.idl View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/FileEntry.h View 1 2 3 4 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/FileEntry.cpp View 1 2 3 4 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/FileEntry.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/FileEntrySync.h View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/FileEntrySync.cpp View 1 2 3 4 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/FileEntrySync.idl View 1 chunk +0 lines, -36 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystem.h View 1 2 3 4 4 chunks +31 lines, -27 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystem.cpp View 1 2 3 4 6 chunks +42 lines, -42 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystem.idl View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemBase.h View 1 2 3 4 7 chunks +41 lines, -39 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemBase.cpp View 1 2 3 4 17 chunks +105 lines, -102 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemBaseTest.cpp View 1 2 3 4 4 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallback.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h View 1 2 3 4 11 chunks +41 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp View 1 2 3 4 16 chunks +74 lines, -65 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryEntry.h View 1 2 3 4 2 chunks +17 lines, -17 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryEntry.cpp View 1 2 3 4 1 chunk +22 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryEntry.idl View 1 2 3 4 1 chunk +7 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryEntrySync.h View 1 2 3 4 1 chunk +18 lines, -18 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryEntrySync.cpp View 1 2 3 4 1 chunk +25 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryEntrySync.idl View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReader.h View 1 2 3 4 4 chunks +17 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReader.cpp View 1 2 3 4 5 chunks +33 lines, -26 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReader.idl View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReaderBase.h View 1 2 3 4 2 chunks +11 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReaderSync.h View 1 2 3 4 3 chunks +13 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReaderSync.cpp View 1 2 3 4 3 chunks +27 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemDirectoryReaderSync.idl View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntriesCallback.h View 1 2 3 4 1 chunk +9 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntriesCallback.idl View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntry.h View 1 2 3 4 1 chunk +20 lines, -19 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntry.cpp View 1 2 3 4 1 chunk +45 lines, -37 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntry.idl View 1 2 3 4 1 chunk +9 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntryBase.h View 1 2 3 4 4 chunks +13 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntryBase.cpp View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntryCallback.h View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntryCallback.idl View 1 chunk +3 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntrySync.h View 1 2 3 4 1 chunk +20 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntrySync.cpp View 1 2 3 4 1 chunk +34 lines, -30 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemEntrySync.idl View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemFileEntry.h View 1 2 3 4 2 chunks +15 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemFileEntry.cpp View 1 2 3 4 1 chunk +11 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemFileEntry.idl View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemFileEntrySync.h View 1 2 3 4 3 chunks +11 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemFileEntrySync.cpp View 1 2 3 4 2 chunks +9 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemFileEntrySync.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemFlags.idl View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemMetadata.h View 1 2 3 4 4 chunks +11 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemMetadata.idl View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemMetadataCallback.h View 1 2 3 4 1 chunk +8 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemMetadataCallback.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemSync.h View 1 2 3 4 1 chunk +23 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemSync.cpp View 1 2 3 4 6 chunks +25 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/modules/filesystem/FileSystemSync.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.cpp View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/filesystem/Metadata.h View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/Metadata.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/MetadataCallback.h View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/modules/filesystem/MetadataCallback.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/SharedWorkerGlobalScopeFileSystem.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h View 1 2 3 4 2 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/WindowFileSystem.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.h View 1 2 3 4 2 chunks +16 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp View 1 2 3 4 6 chunks +17 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 3 4 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMFileSystem.cpp View 1 2 3 4 3 chunks +22 lines, -23 lines 0 comments Download
M third_party/WebKit/public/web/WebDOMFileSystem.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/closure_compiler/externs/file_manager_private.js View 1 2 3 4 10 chunks +605 lines, -259 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/common/js/mock_entry.js View 1 2 3 4 8 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (20 generated)
jsbell
4 years, 1 month ago (2016-11-22 22:36:37 UTC) #18 
Not ready for review.

This runs into problems where definitions inside
third_party/closure_compiler/compiler/compiler.jar:externs.zip:browser/fileapi.js
(where : means "unzip") conflict with
third_party/WebKit/Source/devtools/front_end/externs.js

I may start over with a minimal CL.

Powered by Google App Engine
This is Rietveld 408576698