Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileSystemEntry.idl

Issue 2297043002: Web expose FileSystemFileEntry, FileSystemDirectoryEntry and friends (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/FileSystemEntry.idl
diff --git a/third_party/WebKit/Source/modules/filesystem/Entry.idl b/third_party/WebKit/Source/modules/filesystem/FileSystemEntry.idl
similarity index 68%
rename from third_party/WebKit/Source/modules/filesystem/Entry.idl
rename to third_party/WebKit/Source/modules/filesystem/FileSystemEntry.idl
index 312fb89c555b2bafe2a756a74d0283d6b42f6448..484744a328fd16e2f889d05e899f3228cdca09a9 100644
--- a/third_party/WebKit/Source/modules/filesystem/Entry.idl
+++ b/third_party/WebKit/Source/modules/filesystem/FileSystemEntry.idl
@@ -28,19 +28,20 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-[
- NoInterfaceObject,
-] interface Entry {
+// https://wicg.github.io/entries-api/#api-entry
+interface FileSystemEntry {
readonly attribute boolean isFile;
readonly attribute boolean isDirectory;
readonly attribute DOMString name;
readonly attribute DOMString fullPath;
- [CallWith=ExecutionContext] readonly attribute DOMFileSystem filesystem;
+ [CallWith=ExecutionContext] readonly attribute FileSystem filesystem;
- [CallWith=ExecutionContext] void getMetadata(MetadataCallback successCallback, optional ErrorCallback errorCallback);
- [CallWith=ExecutionContext] void moveTo(DirectoryEntry parent, optional DOMString? name, optional EntryCallback successCallback, optional ErrorCallback errorCallback);
- [CallWith=ExecutionContext] void copyTo(DirectoryEntry parent, optional DOMString? name, optional EntryCallback successCallback, optional ErrorCallback errorCallback);
+ [CallWith=ExecutionContext] void getParent(optional FileSystemEntryCallback successCallback, optional ErrorCallback errorCallback);
+
+ // TODO(jsbell): Only expose in non-isolated file systems.
+ [CallWith=ExecutionContext] void getMetadata(FileSystemMetadataCallback successCallback, optional ErrorCallback errorCallback);
+ [CallWith=ExecutionContext] void moveTo(FileSystemDirectoryEntry parent, optional DOMString? name, optional FileSystemEntryCallback successCallback, optional ErrorCallback errorCallback);
+ [CallWith=ExecutionContext] void copyTo(FileSystemDirectoryEntry parent, optional DOMString? name, optional FileSystemEntryCallback successCallback, optional ErrorCallback errorCallback);
[CallWith=ExecutionContext] DOMString toURL();
[CallWith=ExecutionContext] void remove(VoidCallback successCallback, optional ErrorCallback errorCallback);
- [CallWith=ExecutionContext] void getParent(optional EntryCallback successCallback, optional ErrorCallback errorCallback);
};

Powered by Google App Engine
This is Rietveld 408576698