Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2297003002: remote_run: Don't turn remote_run_result purple on exception (Closed)

Created:
4 years, 3 months ago by martiniss
Modified:
3 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

remote_run: Don't turn remote_run_result purple on exception The linked bug below is the only one I could find on a quick search, but many people have expressed confusion to me about this. BUG=642151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M scripts/slave/remote_run.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
martiniss
PTAL
4 years, 3 months ago (2016-08-30 22:35:48 UTC) #3
Paweł Hajdan Jr.
4 years, 3 months ago (2016-08-31 09:23:57 UTC) #4
Well, technically you'd probably want to revert all of
https://codereview.chromium.org/2133573004 , right?

I think this may need more discussion.

This step is confusing no doubt. However, do we have a better way to ensure a
failure in recipe engine always propagates as infra failure to buildbot
otherwise? I'm specifically referring to e.g. recipe engine crashing before we
run any recipe code and similar scenarios.

Of course the build will still result in failure because of non-zero exit code.
However, it'd be red not purple - obscuring the fact of infra failure.

Given the pushback against alerting on anything but infra failures, such change
may limit our ability to react to infra issues with remote_run.

Powered by Google App Engine
This is Rietveld 408576698