remote_run: make build purple on any infra failures

remote_run: make build purple on any infra failures

Depends on https://codereview.chromium.org/2127353003 .

BUG=593999
Committed: https://chromium.googlesource.com/chromium/tools/build/+/33fbac986289a7ada5ed3105c0bd5a5dec984403

[Paweł Hajdan Jr., 2016-07-08 15:05:47]

phajdan.jr@chromium.org changed reviewers:
+ estaab@chromium.org, iannucci@chromium.org, martiniss@chromium.org

[Paweł Hajdan Jr., 2016-07-08 15:05:52]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 15:06:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2016-07-08 15:11:12]

Description was changed from

==========
remote_run: make build purple on any infra failures

BUG=593999
==========

to

==========
remote_run: make build purple on any infra failures

Depends on https://codereview.chromium.org/2127353003 .

BUG=593999
==========

[Paweł Hajdan Jr., 2016-07-08 15:12:12]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 15:12:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 15:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 15:16:51]

Dry run: This issue passed the CQ dry run.

[martiniss, 2016-07-08 21:10:30]

lgtm but question about creating a new step

https://codereview.chromium.org/2133573004/diff/20001/scripts/slave/remote_ru...
File scripts/slave/remote_run.py (right):

https://codereview.chromium.org/2133573004/diff/20001/scripts/slave/remote_ru...
scripts/slave/remote_run.py:177: with stream.step('remote_run_result'):
Why is this here? You're creating another step before you start running the
recipe?

[Paweł Hajdan Jr., 2016-07-11 11:21:07]

https://codereview.chromium.org/2133573004/diff/20001/scripts/slave/remote_ru...
File scripts/slave/remote_run.py (right):

https://codereview.chromium.org/2133573004/diff/20001/scripts/slave/remote_ru...
scripts/slave/remote_run.py:177: with stream.step('remote_run_result'):
On 2016/07/08 at 21:10:29, martiniss wrote:
> Why is this here? You're creating another step before you start running the
recipe?

Yes, this way I can turn that step purple e.g. on any exceptions.

This was the best use of annotator I could find. I'd be fine if there's a better
alternative.

[Paweł Hajdan Jr., 2016-07-11 11:21:14]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-07-11 11:21:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 11:25:41]

Description was changed from

==========
remote_run: make build purple on any infra failures

Depends on https://codereview.chromium.org/2127353003 .

BUG=593999
==========

to

==========
remote_run: make build purple on any infra failures

Depends on https://codereview.chromium.org/2127353003 .

BUG=593999

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/33fbac986289a7ada5ed...
==========

[commit-bot: I haz the power, 2016-07-11 11:25:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/33fbac986289a7ada5ed...