Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2296973003: Fix removeChildNode to unmark orthogonal writing mode roots when !notifyLayoutObject (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1814 matching lines...) Expand 10 before | Expand all | Expand 10 after
1825 m_layoutSubtreeRootList.remove(const_cast<LayoutObject&>(root)); 1825 m_layoutSubtreeRootList.remove(const_cast<LayoutObject&>(root));
1826 } 1826 }
1827 1827
1828 void FrameView::clearLayoutSubtreeRootsAndMarkContainingBlocks() 1828 void FrameView::clearLayoutSubtreeRootsAndMarkContainingBlocks()
1829 { 1829 {
1830 m_layoutSubtreeRootList.clearAndMarkContainingBlocksForLayout(); 1830 m_layoutSubtreeRootList.clearAndMarkContainingBlocksForLayout();
1831 } 1831 }
1832 1832
1833 void FrameView::addOrthogonalWritingModeRoot(LayoutBox& root) 1833 void FrameView::addOrthogonalWritingModeRoot(LayoutBox& root)
1834 { 1834 {
1835 DCHECK(!root.isLayoutFullScreen() && !root.isLayoutFullScreenPlaceholder() 1835 DCHECK(!root.isLayoutScrollbarPart());
1836 && !root.isLayoutScrollbarPart());
1837 m_orthogonalWritingModeRootList.add(root); 1836 m_orthogonalWritingModeRootList.add(root);
1838 } 1837 }
1839 1838
1840 void FrameView::removeOrthogonalWritingModeRoot(LayoutBox& root) 1839 void FrameView::removeOrthogonalWritingModeRoot(LayoutBox& root)
1841 { 1840 {
1842 m_orthogonalWritingModeRootList.remove(root); 1841 m_orthogonalWritingModeRootList.remove(root);
1843 } 1842 }
1844 1843
1845 bool FrameView::hasOrthogonalWritingModeRoots() const 1844 bool FrameView::hasOrthogonalWritingModeRoots() const
1846 { 1845 {
(...skipping 2477 matching lines...) Expand 10 before | Expand all | Expand 10 after
4324 } 4323 }
4325 4324
4326 bool FrameView::canThrottleRendering() const 4325 bool FrameView::canThrottleRendering() const
4327 { 4326 {
4328 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4327 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4329 return false; 4328 return false;
4330 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4329 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4331 } 4330 }
4332 4331
4333 } // namespace blink 4332 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698