Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229693002: Move modal dialogs from WebViewClient to WebFrameClient, part 3/3. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Move modal dialogs from WebViewClient to WebFrameClient, part 3/3. BUG=304341 TEST=modal dialogs still work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263103

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -73 lines) Patch
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
6 years, 8 months ago (2014-04-08 23:18:06 UTC) #1
jam
lgtm
6 years, 8 months ago (2014-04-09 17:28:27 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-10 15:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/229693002/20001
6 years, 8 months ago (2014-04-10 15:14:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 16:21:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-10 16:21:13 UTC) #6
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-10 19:56:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/229693002/20001
6 years, 8 months ago (2014-04-10 19:56:36 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 22:43:36 UTC) #9
Message was sent while issue was closed. 
Change committed as 263103

Powered by Google App Engine
This is Rietveld 408576698