Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Unified Diff: content/renderer/render_view_impl.cc

Issue 229693002: Move modal dialogs from WebViewClient to WebFrameClient, part 3/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 45942b1fcfe32edc4972ca6e69782aef75da3206..fd4ee1cc0bda653ab70684b65de3859fca715ad5 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1715,60 +1715,6 @@ bool RenderViewImpl::runFileChooser(
return ScheduleFileChooser(ipc_params, chooser_completion);
}
-void RenderViewImpl::runModalAlertDialog(WebLocalFrame* frame,
- const WebString& message) {
- RenderFrameImpl::FromWebFrame(frame)->runModalAlertDialog(message);
-}
-
-bool RenderViewImpl::runModalConfirmDialog(WebLocalFrame* frame,
- const WebString& message) {
- return RenderFrameImpl::FromWebFrame(frame)->runModalConfirmDialog(message);
-}
-
-bool RenderViewImpl::runModalPromptDialog(WebLocalFrame* frame,
- const WebString& message,
- const WebString& default_value,
- WebString* actual_value) {
- return RenderFrameImpl::FromWebFrame(frame)->
- runModalPromptDialog(message, default_value, actual_value);
-}
-
-bool RenderViewImpl::runModalBeforeUnloadDialog(WebLocalFrame* frame,
- const WebString& message) {
- bool is_reload = false;
- WebDataSource* ds = frame->provisionalDataSource();
- if (ds)
- is_reload = (ds->navigationType() == blink::WebNavigationTypeReload);
- return RenderFrameImpl::FromWebFrame(frame)->
- runModalBeforeUnloadDialog(is_reload, message);
-}
-
-void RenderViewImpl::runModalAlertDialog(const WebString& message) {
- /* bogus version of the function to avoid errors */
- NOTIMPLEMENTED();
-}
-
-bool RenderViewImpl::runModalConfirmDialog(const WebString& message) {
- /* bogus version of the function to avoid errors */
- NOTIMPLEMENTED();
- return false;
-}
-
-bool RenderViewImpl::runModalPromptDialog(const WebString& message,
- const WebString& default_value,
- WebString* actual_value) {
- /* bogus version of the function to avoid errors */
- NOTIMPLEMENTED();
- return false;
-}
-
-bool RenderViewImpl::runModalBeforeUnloadDialog(bool is_reload,
- const WebString& message) {
- /* bogus version of the function to avoid errors */
- NOTIMPLEMENTED();
- return false;
-}
-
void RenderViewImpl::showValidationMessage(
const blink::WebRect& anchor_in_root_view,
const blink::WebString& main_text,
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698