Make TestSimpleTaskRunner thread-safe.

Make TestSimpleTaskRunner thread-safe.

From task_runner.h:
 "Implementations of TaskRunner should be thread-safe in that all
  methods must be safe to call on any thread."

The fact that TestSimpleTaskRunner doesn't respect this contract is
confusing. It led to a CL being reverted because it caused a DCHECK
failure inside TestSimpleTaskRunner.
https://codereview.chromium.org/2277333002/

This CL ensures that this won't happen again by making
TestSimpleTaskRunner thread-safe.

BUG=632184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/980375e38eac6b3669a25a0d5f2a8991f57a4d55
Cr-Commit-Position: refs/heads/master@{#416654}

[fdoray, 2016-08-30 21:15:42]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 21:16:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:28:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-08-31 21:07:19]

Description was changed from

==========
Make TestSimpleTaskRunner thread-safe.

From task_runner.h:
 "Implementations of TaskRunner should be thread-safe in that all
  methods must be safe to call on any thread."

The fact that TestSimpleTaskRunner doesn't respect this contract is
confusing. It led to a CL being reverted because it caused a DCHECK
failure inside TestSimpleTaskRunner.
https://codereview.chromium.org/2277333002/

This CL ensures that this won't happen again by making
TestSimpleTaskRunner thread-safe.

BUG=632184
==========

to

==========
Make TestSimpleTaskRunner thread-safe.

From task_runner.h:
 "Implementations of TaskRunner should be thread-safe in that all
  methods must be safe to call on any thread."

The fact that TestSimpleTaskRunner doesn't respect this contract is
confusing. It led to a CL being reverted because it caused a DCHECK
failure inside TestSimpleTaskRunner.
https://codereview.chromium.org/2277333002/

This CL ensures that this won't happen again by making
TestSimpleTaskRunner thread-safe.

BUG=632184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[fdoray, 2016-08-31 21:07:28]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:08:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:18:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-08-31 21:21:55]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-08-31 21:42:57]

fdoray@chromium.org changed reviewers:
+ danakj@chromium.org

[fdoray, 2016-08-31 21:42:58]

PTAL

[commit-bot: I haz the power, 2016-08-31 22:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:13:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-09-01 14:06:58]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 14:07:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-01 15:50:00]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 15:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 19:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:42:04]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-01 21:22:18]

LGTM

https://codereview.chromium.org/2296923003/diff/80001/base/test/test_simple_t...
File base/test/test_simple_task_runner.h (right):

https://codereview.chromium.org/2296923003/diff/80001/base/test/test_simple_t...
base/test/test_simple_task_runner.h:72: ~TestSimpleTaskRunner() override;
nit: idk why this is protected.. maybe make this public while you're here?

[fdoray, 2016-09-02 17:39:15]

fdoray@chromium.org changed reviewers:
+ jochen@chromium.org, pastarmovj@chromium.org

[fdoray, 2016-09-02 17:39:16]

jochen@chromium.org: Please review changes in chrome/browser/

pastarmovj@chromium.org: Please review changes in components/policy/

ortuno@chromium.org: Please review changes in device/bluetooth/

https://codereview.chromium.org/2296923003/diff/80001/base/test/test_simple_t...
File base/test/test_simple_task_runner.h (right):

https://codereview.chromium.org/2296923003/diff/80001/base/test/test_simple_t...
base/test/test_simple_task_runner.h:72: ~TestSimpleTaskRunner() override;
On 2016/09/01 21:22:18, danakj wrote:
> nit: idk why this is protected.. maybe make this public while you're here?

TestSimpleTaskRunner is ref-counted. Having a protected destructor ensures that
nobody deletes it explicitly. Since TestSimpleTaskRunner has derived classes,
its destructor can't be private.

[fdoray, 2016-09-02 17:39:38]

fdoray@chromium.org changed reviewers:
+ ortuno@chromium.org

[fdoray, 2016-09-02 17:39:38]

jochen@chromium.org: Please review changes in chrome/browser/

pastarmovj@chromium.org: Please review changes in components/policy/

ortuno@chromium.org: Please review changes in device/bluetooth/

[ortuno, 2016-09-02 17:47:27]

device/bluetooth lgtm

[danakj, 2016-09-02 20:00:07]

https://codereview.chromium.org/2296923003/diff/80001/base/test/test_simple_t...
File base/test/test_simple_task_runner.h (right):

https://codereview.chromium.org/2296923003/diff/80001/base/test/test_simple_t...
base/test/test_simple_task_runner.h:72: ~TestSimpleTaskRunner() override;
On 2016/09/02 17:39:16, fdoray wrote:
> On 2016/09/01 21:22:18, danakj wrote:
> > nit: idk why this is protected.. maybe make this public while you're here?
> 
> TestSimpleTaskRunner is ref-counted. Having a protected destructor ensures
that
> nobody deletes it explicitly. Since TestSimpleTaskRunner has derived classes,
> its destructor can't be private.

Oh I missed that since it's inheriting that. Thanks.

[jochen (gone - plz use gerrit), 2016-09-05 09:47:39]

the chrome/browser stuff should all be covered by Julian as well

[pastarmovj, 2016-09-05 16:23:01]

lgtm

[fdoray, 2016-09-06 14:01:04]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-06 14:01:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 14:36:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 14:36:55]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-09-06 16:36:33]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 17:47:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-06 17:50:29]

Description was changed from

==========
Make TestSimpleTaskRunner thread-safe.

From task_runner.h:
 "Implementations of TaskRunner should be thread-safe in that all
  methods must be safe to call on any thread."

The fact that TestSimpleTaskRunner doesn't respect this contract is
confusing. It led to a CL being reverted because it caused a DCHECK
failure inside TestSimpleTaskRunner.
https://codereview.chromium.org/2277333002/

This CL ensures that this won't happen again by making
TestSimpleTaskRunner thread-safe.

BUG=632184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Make TestSimpleTaskRunner thread-safe.

From task_runner.h:
 "Implementations of TaskRunner should be thread-safe in that all
  methods must be safe to call on any thread."

The fact that TestSimpleTaskRunner doesn't respect this contract is
confusing. It led to a CL being reverted because it caused a DCHECK
failure inside TestSimpleTaskRunner.
https://codereview.chromium.org/2277333002/

This CL ensures that this won't happen again by making
TestSimpleTaskRunner thread-safe.

BUG=632184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/980375e38eac6b3669a25a0d5f2a8991f57a4d55
Cr-Commit-Position: refs/heads/master@{#416654}
==========

[commit-bot: I haz the power, 2016-09-06 17:50:31]

Patchset 5 (id:??) landed as
https://crrev.com/980375e38eac6b3669a25a0d5f2a8991f57a4d55
Cr-Commit-Position: refs/heads/master@{#416654}