Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

Issue 2296923003: Make TestSimpleTaskRunner thread-safe. (Closed)
Patch Set: fix asan error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
diff --git a/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc b/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
index 6dc51abf780c5d328198ace36db1a14fe31df0d2..ccca1e3be378da62c7d4f318d9fba9ebf9b593a0 100644
--- a/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
+++ b/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
@@ -193,7 +193,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, PayloadSizeExceedsLimit) {
EXPECT_EQ(GURL(kExternalPolicyDataURLs[1]), fetcher->GetOriginalURL());
// Verify that a retry has been scheduled for the first fetch.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
}
TEST_F(ExternalPolicyDataUpdaterTest, FetchFailure) {
@@ -228,7 +228,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, FetchFailure) {
EXPECT_EQ(GURL(kExternalPolicyDataURLs[1]), fetcher->GetOriginalURL());
// Verify that a retry has been scheduled for the first fetch.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
}
TEST_F(ExternalPolicyDataUpdaterTest, ServerFailure) {
@@ -262,7 +262,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, ServerFailure) {
EXPECT_EQ(GURL(kExternalPolicyDataURLs[1]), fetcher->GetOriginalURL());
// Verify that a retry has been scheduled for the first fetch.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
}
TEST_F(ExternalPolicyDataUpdaterTest, RetryLimit) {
@@ -291,7 +291,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, RetryLimit) {
EXPECT_FALSE(fetcher_factory_.GetFetcherByID(fetcher_id));
// Verify that a retry has been scheduled.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
// Fast-forward time to the scheduled retry.
backend_task_runner_->RunPendingTasks();
@@ -349,11 +349,11 @@ TEST_F(ExternalPolicyDataUpdaterTest, RetryWithBackoff) {
EXPECT_FALSE(fetcher_factory_.GetFetcherByID(fetcher_id));
// Verify that a retry has been scheduled.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
// Verify that the retry delay has been doubled, with random jitter from 80%
// to 100%.
- const base::TestPendingTask& task =
+ const base::TestPendingTask task =
backend_task_runner_->GetPendingTasks().front();
EXPECT_GT(task.delay,
base::TimeDelta::FromMilliseconds(
@@ -413,7 +413,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, HashInvalid) {
EXPECT_EQ(GURL(kExternalPolicyDataURLs[1]), fetcher->GetOriginalURL());
// Verify that a retry has been scheduled for the first fetch.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
}
TEST_F(ExternalPolicyDataUpdaterTest, DataRejectedByCallback) {
@@ -447,7 +447,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, DataRejectedByCallback) {
EXPECT_FALSE(fetcher_factory_.GetFetcherByID(0));
// Verify that a retry has been scheduled.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
// Fast-forward time to the scheduled retry.
backend_task_runner_->RunPendingTasks();
@@ -800,7 +800,7 @@ TEST_F(ExternalPolicyDataUpdaterTest, ParallelJobsWithRetry) {
EXPECT_EQ(GURL(kExternalPolicyDataURLs[2]), fetcher->GetOriginalURL());
// Verify that a retry has been scheduled for the first fetch.
- EXPECT_EQ(1u, backend_task_runner_->GetPendingTasks().size());
+ EXPECT_EQ(1u, backend_task_runner_->NumPendingTasks());
// Fast-forward time to the scheduled retry.
backend_task_runner_->RunPendingTasks();

Powered by Google App Engine
This is Rietveld 408576698