Add minidump fuzzer for breakpad.

Add minidump fuzzer for breakpad.

Make fuzzer_test target clone defines, and also noop definitions for a few more variables.

BUG=None

Committed: https://crrev.com/dee978f1ee27b272aeebdc75cecc1ed4f8148eb6
Cr-Commit-Position: refs/heads/master@{#416081}

[Will Harris, 2016-08-30 20:21:16]

Description was changed from

==========
Add minidump fuzzer for breakpad.

BUG=None
==========

to

==========
Add minidump fuzzer for breakpad.

BUG=None
==========

[Will Harris, 2016-08-30 20:21:18]

wfh@chromium.org changed reviewers:
+ thestig@chromium.org

[Will Harris, 2016-08-30 20:21:32]

I (mostly) have no idea what I'm doing.

PTAL.

[Lei Zhang, 2016-08-30 20:53:45]

thestig@chromium.org changed reviewers:
+ mark@chromium.org

[Lei Zhang, 2016-08-30 20:53:46]

+mark: any preferences on where the fuzzers should live?

[Lei Zhang, 2016-08-30 21:00:33]

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn
File breakpad/BUILD.gn (right):

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn#newcode7
breakpad/BUILD.gn:7: import("//testing/libfuzzer/fuzzer_test.gni")
alphabetical order

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn#newco...
breakpad/BUILD.gn:170: "src/processor/exploitability_linux.cc",
Are these all actually needed?

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
File breakpad/minidump_fuzzer.cc (right):

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:1: #include <stddef.h>
Missing copyright ehader.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:28: // This is probably a dodgy cast.
Beh. I wish the Minidump ctor just took a buffer instead of an istream.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:38: bool PrintMinidumpProcess(std::istream& input,
pass by non-const ref

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:65: if (machine_readable) {
But it's always false.

[Mark Mentovai, 2016-08-30 21:08:39]

Will always says that he has no idea what he’s doing!

Since this fuzzes MinidumpProcessor, I guess it should live next to
minidump_processor.cc. Unless we’re planning on adding more fuzzers soon, I
don’t think we need to dedicate a directory to just this one file at this point.

[Will Harris, 2016-08-31 15:30:38]

I don't know if the fuzzer targets will work for the breakpad repos, that's why
I didn't want to put it next to the existing files. I wanted it to live in the
chromium repos.

I don't mind where it lives though ( in fact the original CL had it living where
you suggested, then I realized I didn't want to mess with breakpad deps ).

Turns out this isn't working either; something is wrong... so I might have to
get back to this CL later this week.

[Will Harris, 2016-08-31 17:48:09]

The fuzzer is now actually running... before it was bailing really early as
seek() didn't work on the std::istream.

PTAL?

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn
File breakpad/BUILD.gn (right):

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn#newcode7
breakpad/BUILD.gn:7: import("//testing/libfuzzer/fuzzer_test.gni")
On 2016/08/30 21:00:33, Lei Zhang wrote:
> alphabetical order

Done.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn#newco...
breakpad/BUILD.gn:170: "src/processor/exploitability_linux.cc",
On 2016/08/30 21:00:33, Lei Zhang wrote:
> Are these all actually needed?

../../breakpad/src/processor/exploitability.cc:81: error: undefined reference to
'google_breakpad::ExploitabilityWin::ExploitabilityWin(google_breakpad::Minidump*,
google_breakpad::ProcessState*)'
../../breakpad/src/processor/minidump_processor.cc:1129: error: undefined
reference to 'google_breakpad::NTStatusToString(unsigned int)'
../../breakpad/src/processor/exploitability.cc:85: error: undefined reference to
'google_breakpad::ExploitabilityLinux::ExploitabilityLinux(google_breakpad::Minidump*,
google_breakpad::ProcessState*, bool)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

(yes)

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn#newco...
breakpad/BUILD.gn:267: binary_symlink("minidump_fuzzer") {
I'm not even sure what this does, or whether it's needed.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
File breakpad/minidump_fuzzer.cc (right):

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:1: #include <stddef.h>
On 2016/08/30 21:00:33, Lei Zhang wrote:
> Missing copyright ehader.

Done.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:28: // This is probably a dodgy cast.
On 2016/08/30 21:00:33, Lei Zhang wrote:
> Beh. I wish the Minidump ctor just took a buffer instead of an istream.

Acknowledged.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:38: bool PrintMinidumpProcess(std::istream& input,
On 2016/08/30 21:00:33, Lei Zhang wrote:
> pass by non-const ref

Done.

https://codereview.chromium.org/2296893002/diff/20001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:65: if (machine_readable) {
On 2016/08/30 21:00:33, Lei Zhang wrote:
> But it's always false.

Done.

[Lei Zhang, 2016-08-31 18:37:23]

lgtm

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn
File breakpad/BUILD.gn (right):

https://codereview.chromium.org/2296893002/diff/20001/breakpad/BUILD.gn#newco...
breakpad/BUILD.gn:267: binary_symlink("minidump_fuzzer") {
On 2016/08/31 17:48:09, Will Harris wrote:
> I'm not even sure what this does, or whether it's needed.

Well, presumably it adds a symlink when doing an Android build on Linux? I'm not
familiar with the GN syntax so not exactly sure what's linked. Anyway, cannot
hurt.

https://codereview.chromium.org/2296893002/diff/60001/breakpad/minidump_fuzze...
File breakpad/minidump_fuzzer.cc (right):

https://codereview.chromium.org/2296893002/diff/60001/breakpad/minidump_fuzze...
breakpad/minidump_fuzzer.cc:49: return 0;
return false;

[Will Harris, 2016-08-31 19:51:20]

wfh@chromium.org changed reviewers:
+ ochang@chromium.org

[Will Harris, 2016-08-31 19:52:04]

Thanks.

+ochang can you give this a rs look over to make sure I haven't missed anything
with fuzzer config. I can't put the corpus in just yet but hopefully will find a
suitable one soon.

[Oliver Chang, 2016-08-31 19:54:32]

lgtm

[Will Harris, 2016-08-31 19:55:39]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-08-31 19:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2296893002/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-08-31 19:56:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:59:56]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Will Harris, 2016-09-01 00:04:34]

wfh@chromium.org changed reviewers:
+ aizatsky@chromium.org

[Will Harris, 2016-09-01 00:06:09]

Description was changed from

==========
Add minidump fuzzer for breakpad.

BUG=None
==========

to

==========
Add minidump fuzzer for breakpad.

Make fuzzer_test target clone defines, and also noop definitions for a few more
variables.

BUG=None
==========

[Will Harris, 2016-09-01 00:06:38]

aizatsky -> PTAL at the fuzzer_test.gni changes.

[aizatsky, 2016-09-01 16:02:57]

lgtm

https://codereview.chromium.org/2296893002/diff/120001/breakpad/minidump_fuzz...
File breakpad/minidump_fuzzer.cc (right):

https://codereview.chromium.org/2296893002/diff/120001/breakpad/minidump_fuzz...
breakpad/minidump_fuzzer.cc:73: BPLOG(ERROR) << "MinidumpProcessor::Process
failed";
It's better for fuzzer not to log anything. Do you need this for debugging only
or would you rather hunt for these as asserts?

[aizatsky, 2016-09-01 16:04:15]

The CQ bit was checked by aizatsky@chromium.org

[aizatsky, 2016-09-01 16:04:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, ochang@chromium.org
Link to the patchset: https://codereview.chromium.org/2296893002/#ps120001
(title: "fix")

[commit-bot: I haz the power, 2016-09-01 16:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 16:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 16:08:21]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Will Harris, 2016-09-01 17:29:36]

Patchset #9 (id:160001) has been deleted

[Will Harris, 2016-09-01 17:29:40]

Patchset #8 (id:140001) has been deleted

[Will Harris, 2016-09-01 18:05:22]

Patchset #8 (id:180001) has been deleted

[Will Harris, 2016-09-01 20:43:01]

Patchset #9 (id:220001) has been deleted

[Will Harris, 2016-09-01 20:43:05]

Patchset #8 (id:200001) has been deleted

[Will Harris, 2016-09-01 20:52:49]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-09-01 20:52:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
thestig@chromium.org, aizatsky@chromium.org
Link to the patchset: https://codereview.chromium.org/2296893002/#ps240001
(title: "do not binary_symlink the test")

[commit-bot: I haz the power, 2016-09-01 20:54:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:18:42]

Description was changed from

==========
Add minidump fuzzer for breakpad.

Make fuzzer_test target clone defines, and also noop definitions for a few more
variables.

BUG=None
==========

to

==========
Add minidump fuzzer for breakpad.

Make fuzzer_test target clone defines, and also noop definitions for a few more
variables.

BUG=None
==========

[commit-bot: I haz the power, 2016-09-01 22:18:43]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2016-09-01 22:20:22]

Description was changed from

==========
Add minidump fuzzer for breakpad.

Make fuzzer_test target clone defines, and also noop definitions for a few more
variables.

BUG=None
==========

to

==========
Add minidump fuzzer for breakpad.

Make fuzzer_test target clone defines, and also noop definitions for a few more
variables.

BUG=None

Committed: https://crrev.com/dee978f1ee27b272aeebdc75cecc1ed4f8148eb6
Cr-Commit-Position: refs/heads/master@{#416081}
==========

[commit-bot: I haz the power, 2016-09-01 22:20:23]

Patchset 8 (id:??) landed as
https://crrev.com/dee978f1ee27b272aeebdc75cecc1ed4f8148eb6
Cr-Commit-Position: refs/heads/master@{#416081}