Add minidump fuzzer for breakpad.

breakpad/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/symlink.gni")
 import("//testing/test.gni")
+import("//testing/libfuzzer/fuzzer_test.gni")

[Lei Zhang, 2016/08/30 21:00:33]

alphabetical order

[Will Harris, 2016/08/31 17:48:09]

Done.

 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
 config("tools_config") {
   include_dirs = [
     "src",
     "src/third_party",
   ]
@@ skipping 123 matching lines @@
         "src/third_party/libdisasm/x86_operand_list.h",
       ]
 
       defines = [ "BPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR" ]
 
       configs -= [ "//build/config/compiler:chromium_code" ]
       configs += [ "//build/config/compiler:no_chromium_code" ]
       configs += [ ":tools_config" ]
     }
 
+    fuzzer_test("minidump_fuzzer") {
+      sources = [
+        "minidump_fuzzer.cc",
+        "src/processor/exploitability.cc",
+        "src/processor/minidump.cc",
+        "src/processor/minidump_processor.cc",
+      ]
+
+      deps = [
+        ":stackwalk_common",
+      ]
+
+      include_dirs = [ "src" ]
+
+      libfuzzer_options = [ "close_fd_mask=3" ]
+
+      # Always want these files included regardless of platform.
+      set_sources_assignment_filter([])
+      sources += [
+        "src/processor/exploitability_linux.cc",

[Lei Zhang, 2016/08/30 21:00:33]

Are these all actually needed?

[Will Harris, 2016/08/31 17:48:09]

../../breakpad/src/processor/exploitability.cc:81: error: undefined reference to
'google_breakpad::ExploitabilityWin::ExploitabilityWin(google_breakpad::Minidump*,
google_breakpad::ProcessState*)'
../../breakpad/src/processor/minidump_processor.cc:1129: error: undefined
reference to 'google_breakpad::NTStatusToString(unsigned int)'
../../breakpad/src/processor/exploitability.cc:85: error: undefined reference to
'google_breakpad::ExploitabilityLinux::ExploitabilityLinux(google_breakpad::Minidump*,
google_breakpad::ProcessState*, bool)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

(yes)

+        "src/processor/exploitability_linux.h",
+        "src/processor/exploitability_win.cc",
+        "src/processor/exploitability_win.h",
+        "src/processor/symbolic_constants_win.cc",
+        "src/processor/symbolic_constants_win.h",
+      ]
+    }
+
     executable("microdump_stackwalk") {
       sources = [
         "src/processor/microdump.cc",
         "src/processor/microdump_processor.cc",
         "src/processor/microdump_stackwalk.cc",
       ]
 
       deps = [
         ":stackwalk_common",
         "//build/config/sanitizers:deps",
@@ skipping 68 matching lines @@
     # Aliases for convenience.
     binary_symlink("microdump_stackwalk") {
       binary_label = ":$target_name($host_toolchain)"
     }
     binary_symlink("minidump_stackwalk") {
       binary_label = ":$target_name($host_toolchain)"
     }
     binary_symlink("minidump_dump") {
       binary_label = ":$target_name($host_toolchain)"
     }
+    binary_symlink("minidump_fuzzer") {

[Will Harris, 2016/08/31 17:48:09]

I'm not even sure what this does, or whether it's needed.

[Lei Zhang, 2016/08/31 18:37:22]

Well, presumably it adds a symlink when doing an Android build on Linux? I'm not
familiar with the GN syntax so not exactly sure what's linked. Anyway, cannot
hurt.

+      binary_label = ":$target_name($host_toolchain)"
+    }
   }
 }
 
 # Mac --------------------------------------------------------------------------
 
 if (is_mac) {
   if (current_toolchain == host_toolchain) {
     # TODO(GYP) This should be only 64-bit on Mac. From .gypi:
     # Like ld, dump_syms needs to operate on enough data that it may
     # actually need to be able to address more than 4GB. Use x86_64.
@@ skipping 659 matching lines @@
 
 if (is_android) {
   # TODO(GYP_GONE) Delete this after we've converted everything to GN.
   group("breakpad_unittests_deps") {
     testonly = true
     deps = [
       ":breakpad_unittests",
     ]
   }
 }