Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2296883002: Revert "Percent height content should respect the fixed height of its containing cell" (Closed)

Created:
4 years, 3 months ago by rhogan
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Percent height content should respect the fixed height of its containing cell" Revert this CL and its successors. A new approach will be progressed under 637811. BUG=637811, 627305, 623026, 465096, 468699 Committed: https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54 Cr-Commit-Position: refs/heads/master@{#415588}

Patch Set 1 #

Patch Set 2 : Revert "Calculate border-box dimensions correctly for cells" #

Patch Set 3 : Revert "Calculate border-box dimensions correctly for cells" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -243 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/031-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/031-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt View 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 6 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
eae
LGTM
4 years, 3 months ago (2016-08-30 22:22:37 UTC) #7
eae
Thank you!
4 years, 3 months ago (2016-08-30 22:22:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296883002/20001
4 years, 3 months ago (2016-08-30 23:40:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/61145) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-08-30 23:44:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296883002/40001
4 years, 3 months ago (2016-08-31 09:06:50 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 09:11:33 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 09:13:43 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54
Cr-Commit-Position: refs/heads/master@{#415588}

Powered by Google App Engine
This is Rietveld 408576698