third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2296883002: Revert "Percent height content should respect the fixed height of its containing cell"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2296883002: Revert "Percent height content should respect the fixed height of its containing cell" (Closed)

Patch Set: Revert "Calculate border-box dimensions correctly for cells" Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 846d7cd95e57c5cca051b605b25596f4f84631ac..1310a4ff1b275b77f208d42b70d835a2a9f1f09e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1901,8 +1901,7 @@ LayoutUnit LayoutBlock::availableLogicalHeightForPercentageComputation() const

availableHeight = overrideLogicalContentHeight();

} else if (style.logicalHeight().isFixed()) {

LayoutUnit contentBoxHeight = adjustContentBoxLogicalHeightForBoxSizing(style.logicalHeight().value());

- availableHeight = constrainContentBoxLogicalHeightByMinMax(

- contentBoxHeight - scrollbarLogicalHeight(), LayoutUnit(-1)).clampNegativeToZero();

+ availableHeight = std::max(LayoutUnit(), constrainContentBoxLogicalHeightByMinMax(contentBoxHeight - scrollbarLogicalHeight(), LayoutUnit(-1)));

} else if (style.logicalHeight().hasPercent() && !isOutOfFlowPositionedWithSpecifiedHeight) {

LayoutUnit heightWithScrollbar = computePercentageLogicalHeight(style.logicalHeight());

if (heightWithScrollbar != -1) {