Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2296833003: find_unmapped_histograms.py command-line typo fix (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

find_unmapped_histograms.py command-line typo fix Change --exrta_histograms-file option to --extra_histograms-file. BUG= Committed: https://crrev.com/a2c26c1771476211098d05952df9fd0324d554d7 Cr-Commit-Position: refs/heads/master@{#416285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/metrics/histograms/find_unmapped_histograms.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Adam Rice
Hopefully nobody is relying on the typo for their workflow.
4 years, 3 months ago (2016-09-02 11:56:19 UTC) #2
Ilya Sherman
lgtm
4 years, 3 months ago (2016-09-02 16:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296833003/1
4 years, 3 months ago (2016-09-02 16:14:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 17:03:32 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 17:05:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2c26c1771476211098d05952df9fd0324d554d7
Cr-Commit-Position: refs/heads/master@{#416285}

Powered by Google App Engine
This is Rietveld 408576698