Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: tools/metrics/histograms/find_unmapped_histograms.py

Issue 2296833003: find_unmapped_histograms.py command-line typo fix (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Scans the Chromium source for histograms that are absent from histograms.xml. 5 """Scans the Chromium source for histograms that are absent from histograms.xml.
6 6
7 This is a heuristic scan, so a clean run of this script does not guarantee that 7 This is a heuristic scan, so a clean run of this script does not guarantee that
8 all histograms in the Chromium source are properly mapped. Notably, field 8 all histograms in the Chromium source are properly mapped. Notably, field
9 trials are entirely ignored by this script. 9 trials are entirely ignored by this script.
10 10
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 help='scan within DIRECTORY for histograms [optional, defaults to "%s"]' % 329 help='scan within DIRECTORY for histograms [optional, defaults to "%s"]' %
330 default_root, 330 default_root,
331 metavar='DIRECTORY') 331 metavar='DIRECTORY')
332 parser.add_option( 332 parser.add_option(
333 '--histograms-file', dest='histograms_file_location', 333 '--histograms-file', dest='histograms_file_location',
334 default=default_histograms_path, 334 default=default_histograms_path,
335 help='read histogram definitions from FILE (relative to --root-directory) ' 335 help='read histogram definitions from FILE (relative to --root-directory) '
336 '[optional, defaults to "%s"]' % default_histograms_path, 336 '[optional, defaults to "%s"]' % default_histograms_path,
337 metavar='FILE') 337 metavar='FILE')
338 parser.add_option( 338 parser.add_option(
339 '--exrta_histograms-file', dest='extra_histograms_file_location', 339 '--extra_histograms-file', dest='extra_histograms_file_location',
340 default=default_extra_histograms_path, 340 default=default_extra_histograms_path,
341 help='read additional histogram definitions from FILE (relative to ' 341 help='read additional histogram definitions from FILE (relative to '
342 '--root-directory) [optional, defaults to "%s"]' % 342 '--root-directory) [optional, defaults to "%s"]' %
343 default_extra_histograms_path, 343 default_extra_histograms_path,
344 metavar='FILE') 344 metavar='FILE')
345 parser.add_option( 345 parser.add_option(
346 '--csv', action='store_true', dest='output_as_csv', default=False, 346 '--csv', action='store_true', dest='output_as_csv', default=False,
347 help=( 347 help=(
348 'output as csv for ease of parsing ' + 348 'output as csv for ease of parsing ' +
349 '[optional, defaults to %default]')) 349 '[optional, defaults to %default]'))
(...skipping 26 matching lines...) Expand all
376 logging.warning('No such file: %s', options.extra_histograms_file_location) 376 logging.warning('No such file: %s', options.extra_histograms_file_location)
377 377
378 if options.output_as_csv: 378 if options.output_as_csv:
379 output_csv(unmapped_histograms, location_map) 379 output_csv(unmapped_histograms, location_map)
380 else: 380 else:
381 output_log(unmapped_histograms, location_map, options.verbose) 381 output_log(unmapped_histograms, location_map, options.verbose)
382 382
383 383
384 if __name__ == '__main__': 384 if __name__ == '__main__':
385 main() 385 main()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698