[Extensions] Reuse ChromeExtensionFunctionDetails

[Extensions] Reuse ChromeExtensionFunctionDetails

ChromeExtensionFunctionDetails and ChromeUIThreadExtensionFunction have
many identical methods, and the implementations are nearly identical as
well (down to the comments being replicated). Instead, just give
ChromeUIThreadExtensionFunction a ChromeExtensionFunctionDetails and
use it directly to reduce duplicate code.

BUG=None

Committed: https://crrev.com/eaa93027ecba76e5cb52c878958f49070cd2683f
Cr-Commit-Position: refs/heads/master@{#415790}

[Devlin, 2016-08-31 19:35:54]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 19:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-31 20:18:18]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-08-31 20:18:18]

lazyboy@, mind taking a quick look?

[commit-bot: I haz the power, 2016-08-31 20:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:29:57]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-08-31 20:48:24]

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/chrome_extension_function.h (right):

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/chrome_extension_function.h:25: // DEPRECATED: Please
consider inherting UIThreadExtensionFunction directly.
This message isn't quite right anymore.

Given we want to deprecate ChromeUIThreadEF, this change is expected to be
temporary?

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/chrome_extension_function_details.cc (right):

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/chrome_extension_function_details.cc:94: if
(function_->dispatcher()) {
Feels a bit odd that function::GetAssocWC goes from
function->details->function... oh well.

[Devlin, 2016-08-31 20:56:39]

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/chrome_extension_function.h (right):

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/chrome_extension_function.h:25: // DEPRECATED: Please
consider inherting UIThreadExtensionFunction directly.
On 2016/08/31 20:48:24, lazyboy wrote:
> This message isn't quite right anymore.
> 
> Given we want to deprecate ChromeUIThreadEF, this change is expected to be
> temporary?

Why isn't the message correct?  We are deprecated ChromeUIThreadEF, as it says,
and we will keep around UIThreadExtensionFunction.

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/chrome_extension_function_details.cc (right):

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/chrome_extension_function_details.cc:94: if
(function_->dispatcher()) {
On 2016/08/31 20:48:24, lazyboy wrote:
> Feels a bit odd that function::GetAssocWC goes from
> function->details->function... oh well.

Agreed - but it seems better than having 100% duplicated code, IMO.

[lazyboy, 2016-08-31 21:21:42]

lgtm.

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/chrome_extension_function.h (right):

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/chrome_extension_function.h:25: // DEPRECATED: Please
consider inherting UIThreadExtensionFunction directly.
On 2016/08/31 20:56:39, Devlin wrote:
> On 2016/08/31 20:48:24, lazyboy wrote:
> > This message isn't quite right anymore.
> > 
> > Given we want to deprecate ChromeUIThreadEF, this change is expected to be
> > temporary?
> 
> Why isn't the message correct?  We are deprecated ChromeUIThreadEF, as it
says,
> and we will keep around UIThreadExtensionFunction.

I was looking at the ChromeExtensionFunctionDetails comment. Which I interpreted
incorrectly it seems.

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
File chrome/browser/extensions/chrome_extension_function_details.cc (right):

https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/c...
chrome/browser/extensions/chrome_extension_function_details.cc:94: if
(function_->dispatcher()) {
On 2016/08/31 20:56:39, Devlin wrote:
> On 2016/08/31 20:48:24, lazyboy wrote:
> > Feels a bit odd that function::GetAssocWC goes from
> > function->details->function... oh well.
> 
> Agreed - but it seems better than having 100% duplicated code, IMO.

Acknowledged.

[Devlin, 2016-08-31 22:44:21]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:44:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:49:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 22:51:19]

Description was changed from

==========
[Extensions] Reuse ChromeExtensionFunctionDetails

ChromeExtensionFunctionDetails and ChromeUIThreadExtensionFunction have
many identical methods, and the implementations are nearly identical as
well (down to the comments being replicated). Instead, just give
ChromeUIThreadExtensionFunction a ChromeExtensionFunctionDetails and
use it directly to reduce duplicate code.

BUG=None
==========

to

==========
[Extensions] Reuse ChromeExtensionFunctionDetails

ChromeExtensionFunctionDetails and ChromeUIThreadExtensionFunction have
many identical methods, and the implementations are nearly identical as
well (down to the comments being replicated). Instead, just give
ChromeUIThreadExtensionFunction a ChromeExtensionFunctionDetails and
use it directly to reduce duplicate code.

BUG=None

Committed: https://crrev.com/eaa93027ecba76e5cb52c878958f49070cd2683f
Cr-Commit-Position: refs/heads/master@{#415790}
==========

[commit-bot: I haz the power, 2016-08-31 22:51:20]

Patchset 1 (id:??) landed as
https://crrev.com/eaa93027ecba76e5cb52c878958f49070cd2683f
Cr-Commit-Position: refs/heads/master@{#415790}