Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2296603005: [Extensions] Reuse ChromeExtensionFunctionDetails (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Reuse ChromeExtensionFunctionDetails ChromeExtensionFunctionDetails and ChromeUIThreadExtensionFunction have many identical methods, and the implementations are nearly identical as well (down to the comments being replicated). Instead, just give ChromeUIThreadExtensionFunction a ChromeExtensionFunctionDetails and use it directly to reduce duplicate code. BUG=None Committed: https://crrev.com/eaa93027ecba76e5cb52c878958f49070cd2683f Cr-Commit-Position: refs/heads/master@{#415790}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -65 lines) Patch
M chrome/browser/extensions/chrome_extension_function.h View 2 chunks +4 lines, -0 lines 3 comments Download
M chrome/browser/extensions/chrome_extension_function.cc View 2 chunks +5 lines, -54 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_function_details.cc View 2 chunks +14 lines, -11 lines 3 comments Download

Messages

Total messages: 14 (7 generated)
Devlin
lazyboy@, mind taking a quick look?
4 years, 3 months ago (2016-08-31 20:18:18 UTC) #4
lazyboy
https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/chrome_extension_function.h File chrome/browser/extensions/chrome_extension_function.h (right): https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/chrome_extension_function.h#newcode25 chrome/browser/extensions/chrome_extension_function.h:25: // DEPRECATED: Please consider inherting UIThreadExtensionFunction directly. This message ...
4 years, 3 months ago (2016-08-31 20:48:24 UTC) #7
Devlin
https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/chrome_extension_function.h File chrome/browser/extensions/chrome_extension_function.h (right): https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/chrome_extension_function.h#newcode25 chrome/browser/extensions/chrome_extension_function.h:25: // DEPRECATED: Please consider inherting UIThreadExtensionFunction directly. On 2016/08/31 ...
4 years, 3 months ago (2016-08-31 20:56:39 UTC) #8
lazyboy
lgtm. https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/chrome_extension_function.h File chrome/browser/extensions/chrome_extension_function.h (right): https://codereview.chromium.org/2296603005/diff/1/chrome/browser/extensions/chrome_extension_function.h#newcode25 chrome/browser/extensions/chrome_extension_function.h:25: // DEPRECATED: Please consider inherting UIThreadExtensionFunction directly. On ...
4 years, 3 months ago (2016-08-31 21:21:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296603005/1
4 years, 3 months ago (2016-08-31 22:44:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 22:49:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:51:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaa93027ecba76e5cb52c878958f49070cd2683f
Cr-Commit-Position: refs/heads/master@{#415790}

Powered by Google App Engine
This is Rietveld 408576698