[Extensions] Reuse ChromeExtensionFunctionDetails

chrome/browser/extensions/chrome_extension_function.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
 
+#include "chrome/browser/extensions/chrome_extension_function_details.h"
 #include "extensions/browser/extension_function.h"
 
 class Browser;
 class Profile;
 
 namespace content {
 class WebContents;
 }
 
 namespace extensions {
 class WindowController;
 }
 
 // A chrome specific analog to AsyncExtensionFunction. This has access to a
 // chrome Profile.
 //
 // DEPRECATED: Please consider inherting UIThreadExtensionFunction directly.

[lazyboy, 2016/08/31 20:48:24]

This message isn't quite right anymore.

Given we want to deprecate ChromeUIThreadEF, this change is expected to be
temporary?

[Devlin, 2016/08/31 20:56:39]

Why isn't the message correct?  We are deprecated ChromeUIThreadEF, as it says,
and we will keep around UIThreadExtensionFunction.

[lazyboy, 2016/08/31 21:21:42]

I was looking at the ChromeExtensionFunctionDetails comment. Which I interpreted
incorrectly it seems.

 // Then if you need access to Chrome details, you can construct a
 // ChromeExtensionFunctionDetails object within your function implementation.
 class ChromeUIThreadExtensionFunction : public UIThreadExtensionFunction {
  public:
   ChromeUIThreadExtensionFunction();
 
   Profile* GetProfile() const;
 
   // Gets the "current" browser, if any.
   //
@@ skipping 17 matching lines @@
 
   // Same as above but uses WindowControllerList instead of BrowserList.
   extensions::WindowController* GetExtensionWindowController();
 
   // Gets the "current" web contents if any. If there is no associated web
   // contents then defaults to the foremost one.
   content::WebContents* GetAssociatedWebContents() override;
 
  protected:
   ~ChromeUIThreadExtensionFunction() override;
+
+ private:
+  ChromeExtensionFunctionDetails chrome_details_;
 };
 
 // A chrome specific analog to AsyncExtensionFunction. This has access to a
 // chrome Profile.
 //
 // DEPRECATED: Please consider inherting UIThreadExtensionFunction or
 // AsyncExtensionFunction directly. Then if you need access to Chrome details,
 // you can construct a ChromeExtensionFunctionDetails object within your
 // function implementation.
 class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
@@ skipping 37 matching lines @@
   static bool ValidationFailure(ChromeSyncExtensionFunction* function);
 
  private:
   // If you're hitting a compile error here due to "final" - great! You're doing
   // the right thing, you just need to extend ChromeUIThreadExtensionFunction
   // instead of ChromeSyncExtensionFunction.
   ResponseAction Run() final;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_