chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2296603004: Disable Download button if current tab is showing offline page already, or an error or interstitial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2296603004: Disable Download button if current tab is showing offline page already, or an error or interstitial. (Closed)

Patch Set: fix logic after renaming Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index bff2727279714648427652c471ea961f7eebac9f..c902e47743f32bc30345d9fcfc18eb2b035c81f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -110,7 +110,10 @@ public class AppMenuPropertiesDelegate {

MenuItem offlineMenuItem = menu.findItem(R.id.offline_page_id);

if (offlineMenuItem != null) {

if (ChromeFeatureList.isEnabled("DownloadsUi")) {

- offlineMenuItem.setEnabled(!isChromeScheme && !isIncognito);

+ boolean isValidTab = !currentTab.isOfflinePage()

+ && !currentTab.isShowingErrorPage()

+ && !currentTab.isShowingInterstitialPage();

+ offlineMenuItem.setEnabled(!isChromeScheme && !isIncognito && isValidTab);

Drawable drawable = offlineMenuItem.getIcon();

if (drawable != null) {

int iconTint = ApiCompatibilityUtils.getColor(

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java » ('j') | no next file with comments »