Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 { | 1 { |
| 2 "TestTrial1": [ | 2 "TestTrial1": [ |
| 3 {"group_name": "TestGroup1"} | 3 { |
| 4 "groups": [{"group_name": "TestGroup1"}], | |
| 5 "platforms": ["win"] | |
| 6 } | |
| 4 ], | 7 ], |
| 5 "TestTrial2": [ | 8 "TestTrial2": [ |
| 6 { | 9 { |
| 7 "group_name": "TestGroup2", | 10 "groups": [ |
|
Alexei Svitkine (slow)
2016/08/30 17:59:15
We call these "experiments" server-side. How about
robliao
2016/08/30 18:16:43
jwd suggested that the terminiology was trial and
Alexei Svitkine (slow)
2016/08/30 21:39:50
It's a tricky question and I can see arguments for
robliao
2016/09/01 21:49:07
I made the json format changes. I'd like to adjust
robliao
2016/09/09 00:48:02
https://codereview.chromium.org/2319293006/
contai
| |
| 8 "params": { | 11 { |
| 9 "x": "1", | 12 "group_name": "TestGroup2", |
| 10 "y": "2" | 13 "params": { |
| 11 }, | 14 "x": "1", |
| 12 "enable_features": ["A", "B"], | 15 "y": "2" |
| 13 "disable_features": ["C"] | 16 }, |
| 14 }, | 17 "enable_features": ["A", "B"], |
| 15 { | 18 "disable_features": ["C"] |
| 16 "group_name": "TestGroup2-2", | 19 }, |
| 17 "params": { | 20 { |
| 18 "x": "3", | 21 "group_name": "TestGroup2-2", |
| 19 "y": "4" | 22 "params": { |
| 20 }, | 23 "x": "3", |
| 21 "enable_features": ["D", "E"], | 24 "y": "4" |
| 22 "disable_features": ["F"] | 25 }, |
| 26 "enable_features": ["D", "E"], | |
| 27 "disable_features": ["F"] | |
| 28 } | |
| 29 ], | |
| 30 "platforms": ["win"] | |
|
Alexei Svitkine (slow)
2016/08/30 21:39:50
Can you list platforms first? This is the conventi
robliao
2016/09/01 21:49:07
Done. This also required rewriting the pretty prin
| |
| 23 } | 31 } |
| 24 ], | 32 ], |
| 25 "TestTrial3": [ | 33 "TestTrial3": [ |
| 26 {"group_name": "TestGroup3", "enable_features": ["X"]} | 34 { |
| 35 "groups": [{"group_name": "TestGroup3", "enable_features": ["X"]}], | |
| 36 "platforms": ["win"] | |
| 37 } | |
| 27 ] | 38 ] |
| 28 } | 39 } |
| OLD | NEW |