chrome/common/variations/fieldtrial_testing_config_schema.json - Issue 2259443003: Capture All Groups in the Field Trial For Testing Studies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/variations/fieldtrial_testing_config_schema.json

Issue 2259443003: Capture All Groups in the Field Trial For Testing Studies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Feedback and Change NOTREACHED() to DLOG(ERROR) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 {	5 {

6 "type_name": "FieldTrialTestingConfig",	6 "type_name": "FieldTrialTestingConfig",

7 "schema": [{	7 "schema": [{

8 "field": "groups",	8 "field": "studies",
	jwd 2016/08/22 21:54:08 I disagree with Ilya, the terminology is either (s I disagree with Ilya, the terminology is either (study and experiment) or (field trial and group). I'd probably have prefered you use study/experiment, but that would be inconsistent with the testing configs, so I'd like you to change to the field trial/group consistently, and rename this to "trials" or "field_trials". robliao 2016/08/22 22:55:23 Done. Variations uses trial and group too, so it m Show quoted text On 2016/08/22 21:54:08, jwd wrote: > I disagree with Ilya, the terminology is either (study and experiment) or (field > trial and group). I'd probably have prefered you use study/experiment, but that > would be inconsistent with the testing configs, so I'd like you to change to the > field trial/group consistently, and rename this to "trials" or "field_trials". Done. Variations uses trial and group too, so it makes more sense to stick with that.
9 "type": "array",	9 "type": "array",

10 "contents": {	10 "contents": {

11 "type_name": "FieldTrialTestingGroup",	11 "type_name": "FieldTrialTestingStudy",

12 "type": "struct",	12 "type": "struct",

13 "fields": [	13 "fields": [

14 {"field": "study", "type": "string"},	14 {"field": "name", "type": "string"},

15 {"field": "group_name", "type": "string"},

16 {	15 {

17 "field": "params",	16 "field": "groups",

18 "type": "array",	17 "type": "array",

19 "contents": {	18 "contents": {

20 "type_name": "FieldTrialGroupParams",	19 "type_name": "FieldTrialTestingGroup",

21 "type": "struct",	20 "type": "struct",

22 "fields": [	21 "fields": [

23 {"field": "key", "type": "string"},	22 {"field": "name", "type": "string"},

24 {"field": "value", "type": "string"}	23 {

	24 "field": "params",

	25 "type": "array",

	26 "contents": {

	27 "type_name": "FieldTrialTestingGroupParams",

	28 "type": "struct",

	29 "fields": [

	30 {"field": "key", "type": "string"},

	31 {"field": "value", "type": "string"}

	32 ]

	33 }

	34 },

	35 {

	36 "field": "enable_features",

	37 "type": "array",

	38 "contents": { "type": "string"}

	39 },

	40 {

	41 "field": "disable_features",

	42 "type": "array",

	43 "contents": { "type": "string"}

	44 }

25 ]	45 ]

26 }	46 }

27 },

28 {

29 "field": "enable_features",

30 "type": "array",

31 "contents": { "type": "string"}

32 },

33 {

34 "field": "disable_features",

35 "type": "array",

36 "contents": { "type": "string"}

37 }	47 }

38 ]	48 ]

39 }	49 }

40 }]	50 }]

41 }	51 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/common/variations/variations_util.cc » ('j') | chrome/common/variations/variations_util.cc » ('J')