Issue 22964004: Fix a bug in Div when all uses are truncating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22964004: Fix a bug in Div when all uses are truncating (Closed)

Created:
7 years, 4 months ago by weiliang.lin2

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@master

Visibility:
Public.

Fix a bug in Div when all uses are truncating Refine the related test cases to cover truncating cases BUG= R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16249

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -12 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/shift-for-integer-div.js	View	1	1 chunk	+40 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

Good catch, thanks for the fix! LGTM with comment: The ARM version can be turned ...

7 years, 4 months ago (2013-08-20 13:51:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r16249.