src/x64/lithium-codegen-x64.cc - Issue 22964004: Fix a bug in Div when all uses are truncating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 22964004: Fix a bug in Div when all uses are truncating (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: more elegant ARM version Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index a1f4ad184bfb185073616b4164d556b4ec91ce73..85f025594f9cfb6e7e533ab872a2ed23c51a1ed2 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -1216,6 +1216,7 @@ void LCodeGen::DoDivI(LDivI* instr) {

__ cmpl(dividend, Immediate(0));

__ j(less, &negative, Label::kNear);

__ sarl(dividend, Immediate(power));

+ if (divisor < 0) __ negl(dividend);

__ jmp(&done, Label::kNear);

__ bind(&negative);

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | test/mjsunit/shift-for-integer-div.js » ('j') | no next file with comments »