Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2296353002: Revert of Remove default begin frame sources from the renderer (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
CC:
chromium-reviews, danakj, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove default begin frame sources from the renderer (patchset #11 id:200001 of https://codereview.chromium.org/2083423006/ ) Reason for revert: Speculative revert as there are some bots failing with a common and related stack. Original issue's description: > Remove default begin frame sources from the renderer > > This changes both cc proxies to no longer create default begin frame > sources. In cc, it must either be the case that an external begin frame > source is provided (with use_external_begin_frame_source set) or the > output surface provides a begin frame source (with > use_output_surface_begin_frame_source). > > This changes the world from three states of BFS creation (default, > output surface provided, and external) to only two (output surface > provided and external). In the future, external will also be removed. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889 > Cr-Commit-Position: refs/heads/master@{#415757} TBR=danakj@chromium.org,sievers@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5738e49a21bee482e17e029ff3f4561449131a5e Cr-Commit-Position: refs/heads/master@{#415776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -39 lines) Patch
M cc/output/output_surface_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/surfaces/display.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/fake_output_surface_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/proxy_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.cc View 3 chunks +27 lines, -14 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +25 lines, -13 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 4 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fgorski
Created Revert of Remove default begin frame sources from the renderer
4 years, 3 months ago (2016-08-31 22:15:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296353002/1
4 years, 3 months ago (2016-08-31 22:16:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 22:17:29 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:20:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5738e49a21bee482e17e029ff3f4561449131a5e
Cr-Commit-Position: refs/heads/master@{#415776}

Powered by Google App Engine
This is Rietveld 408576698