Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

webrtc/modules/bitrate_controller/BUILD.gn

Index: webrtc/modules/bitrate_controller/BUILD.gn
diff --git a/webrtc/modules/bitrate_controller/BUILD.gn b/webrtc/modules/bitrate_controller/BUILD.gn
index 029f54170fa241fdc9e7bcc8b5d618f9ecf3c877..f477399f594ba9b34f24e0671ae46bbb64802b49 100644
--- a/webrtc/modules/bitrate_controller/BUILD.gn
+++ b/webrtc/modules/bitrate_controller/BUILD.gn
@@ -10,6 +10,7 @@ import("../../build/webrtc.gni")
 
 source_set("bitrate_controller") {
   sources = [
+    "../remote_bitrate_estimator/test/bwe_test_logging.h",

[kjellander_webrtc, 2016/09/01 19:32:35]

Referencing sources above the target itself is disallowed. I realize we only
have PRESUBMIT check for GYP on this, we'll have to fix that (I filed
https://bugs.chromium.org/p/webrtc/issues/detail?id=6294 for that).

[Gaetano Carlucci, 2016/09/02 10:37:21]

Should we move this file above the target?

[kjellander_webrtc, 2016/09/02 12:05:42]

Not sure what you mean here. If you depend on a header in
remote_bitrate_estimator that module should be in the deps section of this
target, not listed in this target's sources list.

     "bitrate_controller_impl.cc",
     "bitrate_controller_impl.h",
     "include/bitrate_allocator.h",
@@ -18,6 +19,12 @@ source_set("bitrate_controller") {
     "send_side_bandwidth_estimation.h",
   ]
 
+  if (rtc_enable_bwe_test_logging) {
+    defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
+  } else {
+    defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
+  }
+
   configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]