Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

webrtc/modules/bitrate_controller/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 
 source_set("bitrate_controller") {
   sources = [
+    "../remote_bitrate_estimator/test/bwe_test_logging.h",

[kjellander_webrtc, 2016/09/01 19:32:35]

Referencing sources above the target itself is disallowed. I realize we only
have PRESUBMIT check for GYP on this, we'll have to fix that (I filed
https://bugs.chromium.org/p/webrtc/issues/detail?id=6294 for that).

[Gaetano Carlucci, 2016/09/02 10:37:21]

Should we move this file above the target?

[kjellander_webrtc, 2016/09/02 12:05:42]

Not sure what you mean here. If you depend on a header in
remote_bitrate_estimator that module should be in the deps section of this
target, not listed in this target's sources list.

     "bitrate_controller_impl.cc",
     "bitrate_controller_impl.h",
     "include/bitrate_allocator.h",
     "include/bitrate_controller.h",
     "send_side_bandwidth_estimation.cc",
     "send_side_bandwidth_estimation.h",
   ]
 
+  if (rtc_enable_bwe_test_logging) {
+    defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
+  } else {
+    defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
+  }
+
   configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     "../../system_wrappers",
   ]
 }