Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: webrtc/modules/remote_bitrate_estimator/BUILD.gn

Issue 2296253002: Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true (Closed)
Patch Set: synchronizing remote_bitrate_estimator.gypi Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/BUILD.gn
diff --git a/webrtc/modules/remote_bitrate_estimator/BUILD.gn b/webrtc/modules/remote_bitrate_estimator/BUILD.gn
index bbf74aba7ccbcb06d55eb56275443291df7c9add..9d09f8dfb5bdbac0cdd6a2a1ecc181d8ee1e2b4c 100644
--- a/webrtc/modules/remote_bitrate_estimator/BUILD.gn
+++ b/webrtc/modules/remote_bitrate_estimator/BUILD.gn
@@ -9,11 +9,6 @@
import("../../build/webrtc.gni")
import("//testing/test.gni")
-declare_args() {
- # Set this to true to enable BWE test logging.
- rtc_enable_bwe_test_logging = false
-}
-
source_set("remote_bitrate_estimator") {
sources = [
"aimd_rate_control.cc",
@@ -40,11 +35,13 @@ source_set("remote_bitrate_estimator") {
"transport_feedback_adapter.h",
]
- if (rtc_enable_bwe_test_logging) {
- defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
- sources += [ "test/bwe_test_logging.cc" ]
- } else {
- defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
+ if (!rtc_include_tests) {
+ if (rtc_enable_bwe_test_logging) {
+ defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
+ sources += [ "test/bwe_test_logging.cc" ]
+ } else {
+ defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
+ }
}
configs += [ "../..:common_config" ]
@@ -66,6 +63,7 @@ if (rtc_include_tests) {
source_set("bwe_simulator") {
testonly = true
sources = [
+ "bwe_simulations.cc",
"test/bwe.cc",
"test/bwe.h",
"test/bwe_test.cc",

Powered by Google App Engine
This is Rietveld 408576698