webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi - Issue 2296253002: Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi

Issue 2296253002: Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true (Closed)

Patch Set: synchronizing remote_bitrate_estimator.gypi Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi

index 7978576845665c425116d803f3981e07a82e2ed0..a51a9d84e406e8bcf2afe5163b001315fdd4c821 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi

@@ -47,13 +47,17 @@

'test/bwe_test_logging.h',

], # source

'conditions': [

- ['enable_bwe_test_logging==1', {

- 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1' ],

- 'sources': [

- 'test/bwe_test_logging.cc'

+ ['include_tests==0', {

+ 'conditions': [

+ ['enable_bwe_test_logging==1', {

+ 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1' ],

+ 'sources': [

+ 'test/bwe_test_logging.cc'

+ ],

+ }, {

+ 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0' ],

+ }],

- }, {

- 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0' ],

}],

@@ -71,6 +75,7 @@

'<(DEPTH)/testing/gmock.gyp:gmock',

'sources': [

+ 'bwe_simulations.cc',

'test/bwe.cc',

'test/bwe.h',

'test/bwe_test.cc',