Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2296043004: [DevTools] Various tweaks to inspector_protocol. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Various tweaks to inspector_protocol. - allow importing all domains in single header; - support for <includes.h>; - separate export macro/header for lib, protocol and exported; - improved code for defaults. BUG=637032 Committed: https://crrev.com/9f0f2b6fa647284df16706073cd7b916ab9f6af3 Cr-Commit-Position: refs/heads/master@{#415753}

Patch Set 1 #

Patch Set 2 : better #

Patch Set 3 : optional exports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -68 lines) Patch
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 2 5 chunks +39 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/BackendCallback_h.template View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/DispatcherBase_h.template View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/ErrorSupport_h.template View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/Forward_h.template View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/FrontendChannel_h.template View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/Object_h.template View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/Parser_h.template View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/lib/Values_h.template View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/sample_config.json View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/templates/Exported_h.template View 1 2 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/templates/Imported_h.template View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_h.template View 1 2 9 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/inspector_protocol_config.json View 1 2 2 chunks +9 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-08-31 00:09:40 UTC) #2
pfeldman
lgtm
4 years, 3 months ago (2016-08-31 19:43:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296043004/40001
4 years, 3 months ago (2016-08-31 20:22:24 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 21:15:42 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:17:29 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f0f2b6fa647284df16706073cd7b916ab9f6af3
Cr-Commit-Position: refs/heads/master@{#415753}

Powered by Google App Engine
This is Rietveld 408576698