Issue 2296043002: Removed warnings from service tests

Issue 2296043002: Removed warnings from service tests (Closed)

Created:
4 years, 3 months ago by cbernaschina

Modified:
4 years, 3 months ago

Reviewers:
turnidge, rmacnak, Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Removed warnings from service tests R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8561986221eda91ce092225800722606310b4ba2

Patch Set 2 : Fixing line numbers #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
M	runtime/observatory/.analysis_options	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/observatory/tests/service/evaluate_in_sync_star_activation_test.dart	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

https://codereview.chromium.org/2296043002/diff/1/runtime/observatory/.analysis_options File runtime/observatory/.analysis_options (right): https://codereview.chromium.org/2296043002/diff/1/runtime/observatory/.analysis_options#newcode5 runtime/observatory/.analysis_options:5: - tests/service/evaluate_in_async_star_activation_test.dart Are the evaluate ones still broken?

4 years, 3 months ago (2016-08-30 23:42:11 UTC) #3

cbernaschina

4 years, 3 months ago (2016-08-31 00:01:15 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8561986221eda91ce092225800722606310b4ba2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages