runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart - Issue 2296043002: Removed warnings from service tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart

Issue 2296043002: Removed warnings from service tests (Closed)

Patch Set: Fixing line numbers Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/.analysis_options ('k') | runtime/observatory/tests/service/evaluate_in_sync_star_activation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart

diff --git a/runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart b/runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart

index de9b3972b355c74bb96fd6fe6a4e3bbe9091639c..41274a82f972f5c7e422f107e2bf15a07e98761f 100644

--- a/runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart

+++ b/runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart

@@ -2,7 +2,6 @@

// BSD-style license that can be found in the LICENSE file.

-import 'dart:async';

import 'dart:developer';

import 'package:observatory/service_io.dart';

import 'package:unittest/unittest.dart';

@@ -32,7 +31,7 @@ hasStoppedAtBreakpoint,

var stack = await isolate.getStack();

var topFrame = 0;

expect(stack.type, equals('Stack'));

- expect(await stack['frames'][topFrame].location.getLine(), 16);

+ expect(await stack['frames'][topFrame].location.getLine(), 15);

var result = await isolate.evalFrame(topFrame, "x");

print(result);

@@ -48,7 +47,7 @@ hasStoppedAtBreakpoint,

var stack = await isolate.getStack();

var topFrame = 0;

expect(stack.type, equals('Stack'));

- expect(await stack['frames'][topFrame].location.getLine(), 19);

+ expect(await stack['frames'][topFrame].location.getLine(), 18);

var result = await isolate.evalFrame(topFrame, "z");

print(result);