Issue 229593002: rAc: don't DCHECK() when switching from Wallet -> Autofill with only 1 name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 229593002: rAc: don't DCHECK() when switching from Wallet -> Autofill with only 1 name. (Closed)

Created:
6 years, 8 months ago by Dan Beam

Modified:
6 years, 8 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

rAc: don't DCHECK() when switching from Wallet -> Autofill with only 1 name. This can happen after the account_chooser_model has been changed to the new data source but before all the suggestions have been updated. In this small amount of time we snapshot SECTION_CC_BILLING while the account chooser doesn't have wallet selected. R=estade@chromium.org BUG=361321 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262921

Patch Set 1 #

Patch Set 2 : asdf #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/229593002/20001

6 years, 8 months ago (2014-04-09 23:50:56 UTC) #5

Message was sent while issue was closed.

Change committed as 262921

Expand Messages | Collapse Messages